Migration: Add health_state and power_state columns to physical server #14042
Conversation
rodneyhbrown7
changed the title
|
Closing to re-initiate travis tests. |
|
Reopen to run travis tests |
|
Missing addition of new column to Otherwise LGTM 👍 |
|
Checked commits https://github.com/lenovo/manageiq/compare/4ff1b4652cd880c7358555516968e5c9ebe44473~...686c805555453db79073eb7328e99252a31c14be with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot remove_label wip |
miq-bot
changed the title
|
@juliancheal @blomquisg Could you review this? |
|
Hi @juliancheal @blomquisg, @Fryguy How do you see this PR? Schema freeze is getting close |
| @@ -0,0 +1,5 @@ | |||
| class AddPowerStatePropertyToPhysicalServer < ActiveRecord::Migration[5.0] | |||
| def change | |||
| add_column :physical_servers, :power_state, :string | |||
There was a problem hiding this comment.
My only concern is that in the other tables we have separated the concept of "raw_power_state" and "power state". "raw_power_state" is the raw string that we get from the provider, whereas "power_state" is a normalized value, mainly used for reporting. cc @blomquisg
I'll merge anyway, but you might need a followup PR to add "raw_power_state". Also, please be sure that usage of the power state column is limited to the regular normalized values (like what we show in the quadicons in the UI.
@miq-bot add_label: wip, providers/physical-infrastructure