dialog_field_refresh - drop unused code #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only 2 of the original dialog helpers are now used anywhere, neither uses the field refresh functionality this was originally used to run automate dialogs, before the dialog-user angular rewrite
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/7e575255bbe9252c603ed681d5da0a316fdf473d with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
✂️ 🔥 ✂️ 🔥 ✂️ 🔥 🍰 🍪 👏 🙇 😍 🎉 I approve of this PR. There's so much red, what's not to love? |
h-kataria
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only 2 of the original dialog helpers are now used anywhere,
neither uses the field refresh functionality - removing.
this was originally used to run automate dialogs, before the dialog-user angular rewrite (#4374 and related; continues #5864)
Cc @mzazrivec