Merge pull request #7519 from himdel/dialog-field-refresh

dialog_field_refresh - drop unused code
ManageIQ · Nov 19, 2020 · 9d77915 · 9d77915
2 parents 8192895 + 7e57525
commit 9d77915
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 2,033 deletions.
diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
@@ -15,7 +15,6 @@
 //= require ./miq_qe
 //= require ./git_import
 //= require ./automate_import_export
-//= require ./dialog_field_refresh
 //= require ./miq_c3_config
 //= require ./miq_ujs_bindings
 //= require ./miq_tree

diff --git a/app/assets/javascripts/dialog_field_refresh.js b/app/assets/javascripts/dialog_field_refresh.js
diff --git a/app/assets/javascripts/miq_application.js b/app/assets/javascripts/miq_application.js
@@ -1,4 +1,4 @@
-/* global add_flash dialogFieldRefresh getChartColumnDataValues getChartFormatedValue miqBrowserDetect miqExpressionPrefill miqFlashLater miqFlashSaved miqGridCheckAll miqGridGetCheckedRows miqLoadTL miqMenu miqTreeObject miqValueStylePrefill performFiltering recalculateChartYAxisLabels */
+/* global add_flash getChartColumnDataValues getChartFormatedValue miqBrowserDetect miqExpressionPrefill miqFlashLater miqFlashSaved miqGridCheckAll miqGridGetCheckedRows miqMenu miqTreeObject miqValueStylePrefill recalculateChartYAxisLabels */
 
 // MIQ specific JS functions
 
@@ -853,16 +853,9 @@ function miqSendDateRequest(el) {
   //  tack on the id and value to the URL
   var urlstring = url + '?' + el.prop('id') + '=' + el.val();
 
-  var attemptAutoRefreshTrigger = function() {
-    if (parms.auto_refresh === true) {
-      dialogFieldRefresh.triggerAutoRefresh(parms);
-    }
-  };
-
   var options = {
     beforeSend: !!el.attr('data-miq_sparkle_on'),
     complete: !!el.attr('data-miq_sparkle_off'),
-    done: attemptAutoRefreshTrigger,
   };
 
   return miqObserveRequest(urlstring, options);

diff --git a/app/assets/javascripts/miq_ujs_bindings.js b/app/assets/javascripts/miq_ujs_bindings.js
@@ -1,4 +1,4 @@
-/* global dialogFieldRefresh miqCheckForChanges miqCheckMaxLength miqJqueryRequest miqMenuChangeRow miqObserveRequest miqSendDateRequest miqSendOneTrans miqSerializeForm miqSparkle miqSparkleOn */
+/* global miqCheckForChanges miqCheckMaxLength miqJqueryRequest miqMenuChangeRow miqObserveRequest miqSendDateRequest miqSendOneTrans miqSerializeForm miqSparkle miqSparkleOn */
 
 // MIQ unobtrusive javascript bindings run when document is fully loaded
 
@@ -65,15 +65,6 @@ $(document).ready(function() {
     $(this).data('params', miqSerializeForm(form_id));
   });
 
-  // Bind in the observe support. If interval is configured, use the observe_field function
-  var attemptAutoRefreshTrigger = function(parms) {
-    return function() {
-      if (parms.auto_refresh === true) {
-        dialogFieldRefresh.triggerAutoRefresh(parms);
-      }
-    };
-  };
-
   var observeWithInterval = function(el, parms) {
     if (el.data('isObserved')) {
       return;
@@ -90,20 +81,17 @@ $(document).ready(function() {
         // If submit element passed in
         miqObserveRequest(url, {
           data: miqSerializeForm(submit),
-          done: attemptAutoRefreshTrigger(parms),
         });
       } else if (oneTrans) {
         miqSendOneTrans(url, {
           observe: true,
-          done: attemptAutoRefreshTrigger(parms),
         });
       } else {
         // tack on the id and value to the URL
         var data = {};
         data[el.attr('id')] = el.prop('value');
 
         miqObserveRequest(url, {
-          done: attemptAutoRefreshTrigger(parms),
           data: data,
         });
       }
@@ -125,7 +113,6 @@ $(document).ready(function() {
         data: id + '=' + value,
         beforeSend: !!el.attr('data-miq_sparkle_on'),
         complete: !!el.attr('data-miq_sparkle_off'),
-        done: attemptAutoRefreshTrigger(parms),
       });
     }, 700, {leading: true, trailing: true}));
   };
@@ -153,7 +140,6 @@ $(document).ready(function() {
       data: id + '=' + value,
       beforeSend: !!el.attr('data-miq_sparkle_on'),
       complete: !!el.attr('data-miq_sparkle_off'),
-      done: attemptAutoRefreshTrigger(parms),
     });
   });
 
@@ -170,7 +156,6 @@ $(document).ready(function() {
       data: id + '=' + value,
       beforeSend: !!el.attr('data-miq_sparkle_on'),
       complete: !!el.attr('data-miq_sparkle_off'),
-      done: attemptAutoRefreshTrigger(parms),
     });
 
     event.stopPropagation();