Drop legacy dialog user #5864
Drop legacy dialog user #5864
Conversation
|
👍 |
|
Way to go! We need to keep finishing things or we drawn in legacy. |
skateman
force-pushed
the
drop-legacy-dialogs
branch
from
9a70c8e to
0474e40
Compare
skateman
force-pushed
the
drop-legacy-dialogs
branch
from
0474e40 to
af94a05
Compare
|
🎉 |
| @@ -12,43 +12,15 @@ | |||
| - resource_action_id ||= @dialog_locals[:resource_action_id] | |||
| - open_url ||= @dialog_locals[:open_url] | |||
|
|
|||
| - if Settings.product.old_dialog_user_ui | |||
There was a problem hiding this comment.
I remembered that this branch was used somewhere in provisioning, however I couldn't reproduce it, so maybe my memory is just tricking me.
Assuming that this branch is not used anymore, first line - wf = @edit[:wf] if @edit && @edit[:wf] could be also deleted.
Originally i thought that because of this cleanup we might be able to get rid of some parts of miq_request_methods.rb but in _prov_wf.html.haml we are still using wf dialogs.
|
...waiting for @PanSpagetka 's feedback to be addressed. |
skateman
force-pushed
the
drop-legacy-dialogs
branch
from
af94a05 to
dd3d470
Compare
|
Checked commits skateman/manageiq-ui-classic@37aa81c~...dd3d470 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
After we're done with #5539, it will be probably safe to drop the legacy dialog user and get rid of a lot of unnecessary code.
@miq-bot add_reviewer @romanblanco
@miq-bot add_reviewer @PanSpagetka
@miq-bot add_reviewer @martinpovolny
@miq-bot add_label automation/automate, cleanup, ivanchuk/no, changelog/yes, old dialogs
cc @pkomanek, @eclarizio, @d-m-u