Set typ of tab before checking privilegies #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
ZitaNemeckova
force-pushed
the
fix_ae_miq_request
branch
2 times, most recently
from
eb52342 to
2e93552
Compare
ZitaNemeckova
force-pushed
the
fix_ae_miq_request
branch
from
2e93552 to
fc0dcf1
Compare
|
Checked commit ZitaNemeckova@fc0dcf1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
ZitaNemeckova
changed the title
|
👍 I like that the exception is local to the controller. |
|
@miq-bot remove_label wip @romanblanco please review, thanks :) |
miq-bot
changed the title
|
@miq-bot add_label automation/automate, ivanchuk/yes |
mzazrivec
approved these changes
Sep 10, 2019
simaishi
pushed a commit
that referenced
this pull request
Oct 31, 2019
Set typ of tab before checking privilegies (cherry picked from commit d806e2f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767647
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746386
Create a Role that has Automate/Requests checked in feature tree but NOT Services/Request. Create a group with this Role. Create a User with this group. Switch to this user. Go to Automation -> Automate -> Requests.
Before:
After:
Introduced by #4752 . After that change it never went through
index(that is always allowed becausemiq_request_indexis not a feature) sets@request_tabcorrectly before anothercheck_privileges. The tab (?typ=host) that would have the same problem was removed in #4169 .@miq-bot add_label wip, bug, blocker