Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to host provisioning #4169

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Remove references to host provisioning #4169

merged 1 commit into from
Jul 12, 2018

Conversation

gmcculloug
Copy link
Member

Remove host provisioning references from files and specs

Related to ManageIQ/manageiq#17604

@gmcculloug gmcculloug force-pushed the expunge_host_provisioning branch from 93e7e38 to b0040ec Compare June 19, 2018 20:18
@gmcculloug
Copy link
Member Author

@miq-bot add_label wip

@miq-bot miq-bot changed the title Remove references to host provisioning [WIP] Remove references to host provisioning Jun 19, 2018
@miq-bot miq-bot added the wip label Jun 19, 2018
@gmcculloug gmcculloug mentioned this pull request Jun 19, 2018
Merged
5 tasks
bdunne
bdunne reviewed Jul 3, 2018
View reviewed changes
app/controllers/application_controller/miq_request_methods.rb
@@ -519,7 +509,6 @@ def dialog_partial_for_workflow
case workflow
when MiqProvisionVirtWorkflow then "shared/views/prov_dialog"
when ManageIQ::Providers::Foreman::ConfigurationManager::ProvisionWorkflow then "prov_configured_system_foreman_dialog"
when MiqHostProvisionWorkflow then "prov_host_dialog"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also be able to remove ./app/views/miq_request/_prov_host_dialog.html.haml, right?

@gmcculloug gmcculloug force-pushed the expunge_host_provisioning branch 2 times, most recently from 98c1d2b to 006dea2 Compare July 4, 2018 13:05
@gmcculloug
Copy link
Member Author

@miq-bot remove_label wip
@miq-bot add_label technical debt

@dclarizio Please assign for review.

@miq-bot miq-bot changed the title [WIP] Remove references to host provisioning Remove references to host provisioning Jul 5, 2018
@miq-bot miq-bot added technical debt and removed wip labels Jul 5, 2018
@h-kataria
Copy link
Contributor

looks good. @gmcculloug you also need to remove Host Provisioning related references from core repo from:
https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_shortcuts.yml#L167
https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml#L188-L237

@gmcculloug gmcculloug force-pushed the expunge_host_provisioning branch from 006dea2 to 041dd75 Compare July 8, 2018 19:50
@gmcculloug
Copy link
Member Author

@h-kataria Thanks. I found a few more areas that were references HostMiqRequestNew. Also updated the main repo PR.

Please take another look.

@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2018

This pull request is not mergeable. Please rebase and repush.

@h-kataria
Copy link
Contributor

looks good

@h-kataria
Copy link
Contributor

@gmcculloug can you rebase/repush

@gmcculloug gmcculloug force-pushed the expunge_host_provisioning branch from 041dd75 to acb4316 Compare July 12, 2018 12:10
@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2018

Checked commit gmcculloug@acb4316 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug
Copy link
Member Author

@h-kataria Updated, PTAL

@h-kataria
Copy link
Contributor

LGTM

@h-kataria h-kataria added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 12, 2018
@h-kataria h-kataria merged commit 04b79c0 into ManageIQ:master Jul 12, 2018
@romanblanco romanblanco mentioned this pull request Sep 6, 2018
Merged
This was referenced Sep 6, 2019
Merged
Merged
@himdel himdel mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees

@h-kataria h-kataria

Labels
compute/infrastructure technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmcculloug @h-kataria @miq-bot @bdunne @dclarizio