Remove references to host provisioning

[gmcculloug]

Remove files and specs related to Host Provisioning

Links

Depends on:

• Remove references to host provisioning manageiq-content#332
• Remove references to host provisioning manageiq-automation_engine#188
• Remove references to host provisioning manageiq-api#402
• Remove references to host provisioning manageiq-ui-classic#4169
• Remove Host Provisioning references manageiq-schema#235

[Fryguy]

@jrafanie This one's for you! 🎉

[jrafanie]

@gmcculloug My only comment is ✂️ 🗑 🚽

Just kidding. Are you sure you got it all??? This is your opportunity to snap lots of delete lines and avoid confusion months down the line when someone finds a remnant and realizes it's not needed anymore.

[gmcculloug]

@jrafanie My first pass was to search for miq_host_prov and MiqHostProv to find the obvious ones. If you have specific areas of concern feel free to mention them here and I'll give them increased scrutiny. I don't want you getting any credit for my deletes. 😄

[Fryguy]

cc @bdunne

[jrafanie]

@gmcculloug Looks like a pretty clean deletion. I'm impressed. Do we need to have a migration to remove any rows. For example, since class MiqHostProvision < MiqRequestTask, could we have some rows in miq_request_tasks that have this MiqHostProvision class that we won't be able to instantiate after the code is gone? Looks like we use IPMI and PXE, do we have any remnants in other tables that we can't instantiate after this class is gone? miq_queue, miq_tasks, etc.

[gmcculloug]

I believe it is very unlikely, but not impossible, that records exist. I'll look into putting a migration together. As for IPMI and PXE I would not expect any issues but will review this and the queue/task records as well.

[bdunne]

✂️ 🔥 🚽 👍

[miq-bot]

Checked commit gmcculloug@0164e36 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 0 offenses detected
Everything looks fine. 🍰

[jrafanie]

@gmcculloug Were there any other deletions you wanted to add to this PR or can we ?

[gmcculloug]

@jrafanie I need to finish the UI PR first, I think I over did it somewhere as my last round of changes there are causing issues when I test the UI. I'll definitely let you know when dependencies are merged and this is ready.

[bdunne]

@gmcculloug All set now that the UI PR is merged?

[gmcculloug]

Yes, I can work on the migration PR outside of this being merged. 👍

[jrafanie]

✂️ 🔥 ✂️ 🔥 ✂️ 🔥

🍰 🍪 👏 🙇 😍 🎉