[WIP] Move patternfly out of asset pipeline #5679
Conversation
|
(Note to self: #5622 (comment) |
|
Aand currently blocked by patternfly/patternfly#1176, |
coffee-rails is not needed, we have no external assets through the asset pipeline anymore and no coffeescript code sass-rails is replaced in purpose by sass-loader & node-sass from npm patternfly-sass is replaced by the patternfly npm package added @manageiq/font-fabulous to replace the font-fabulous gem (font awesome is already required by patternfly)
so that we can tell imports from external packages from imports from local files
just moved every file from app/assets/stylesheets/, except for application.css and changed print.css to require ui-components via an import, instead of the asset pipeline css require comment
…ion.css this imports everything that used to be required by application.css (which leaves 2 files unsolved... miq_debug.css used from application.haml print.scss used from layouts/print (+any remaining stylesheet tags) )
patternfly-sprockets doesn't actually load anything except for setting vars (it loads fontawesome-sprockets and boostrap-sprockets, but neither loads anything else)
…elpers seems sass-loader is compatible enough with the sprockets way for this to do the right thing and find the right fonts and images (What it won't do is prefer our images to patternfly images with the same name.)
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/e2d5381506052ac43960e98a1cb078fd6b6020e1~...7d710d6d7182d82bc260481f43dde0668ba2b358 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
The download_pdf tests still need this. Martin is replacing the print stylesheet which should be the last area that still needs yarn: app/assets/stylesheets/print.scss 4: *= require @manageiq/ui-components/dist/css/ui-components We can hopefully drop this commit when this PR is ready to go: ManageIQ#5679
The download_pdf tests still need this. Martin is replacing the print stylesheet which should be the last area that still needs yarn: app/assets/stylesheets/print.scss 4: *= require @manageiq/ui-components/dist/css/ui-components We can hopefully drop this commit when this PR is ready to go: ManageIQ#5679
The download_pdf tests still need this. Martin is replacing the print stylesheet which should be the last area that still needs yarn: app/assets/stylesheets/print.scss 4: *= require @manageiq/ui-components/dist/css/ui-components We can hopefully drop this commit when this PR is ready to go: ManageIQ#5679
|
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
|
This pull request is not mergeable. Please rebase and repush. |
|
This is being addressed in #7838. |
Patternfly (together with fonts and bootstrap css) is the only remaining external asset going throught the asset pipeline.
This PR:
moves our local stylesheets to webpack - under
app/stylesheet/legacy/, included byapp/stylesheet/application-webpack.scss(because we're@importing patternfly from those)removes remaining
requiresprockets comments (for css), replaced by@importremoves font-fabulous & patternfly-sass gems, we already have patternfly as a npm dependency, adding font fabulous as well
removes coffee-rails and sass-rails gems, as there's no remaining sass or coffeescript going throug the asset pipeline
TODO creates a separate
printwebpack pack for the print layout which does not load most JS dependencies, but still needs all the CSSTODO changes all stylesheet_tag (etc) to use webpack packs instead
TODO changes loading of miq_debug.css to always (no conflicts, easier than conditional css)
TODO remove css from asset precompile list
TODO our images overiding patternfly images of the same name