-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon - add carbon scss #7068
Carbon - add carbon scss #7068
Conversation
and disabling IBM fonts for now, until we get patternfly over webpack after that, https://github.com/bholloway/resolve-url-loader/blob/master/packages/resolve-url-loader/README.md we may need to use a custom `join` function to change font urls from fonts.gstatic.com
setting the html font size changes the rem units to the actual carbon defaults, so we get some menu sizing for free patternfly overrides body font-size, so this doesn't break patternfly styling
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/2ce268e42ba9968bf9b02148ac6e163f89e579df~...0affc237f4a80924a43626dc798b3ae162eb5b4d with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Is this changing anything visually? |
No, it shouldn't change anything visually. |
I assume you're aware of these new warnings:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in #7072 :) |
Carbon - add carbon scss (cherry picked from commit 9cfcf1c)
Jansa backport details:
|
(Split off from #6963 as it was getting too large.)
This enables carbon css without affecting anything.
This PR should cause no visual differences at all :).
ui-shell css is needed for the new menu (#6963),
not switching to IBM fonts globally because:
fonts.gstatic.com
, we may need need to use a custom join function to change to local urlsalso #5679 - switching reset stylesheets can wait, and body styling and typography can change after that.
Overriding html font-size to 100% to get reasonable styling from carbon use of rem units, patternfly sets body to 12px.
Issue: #6817
cc @skateman