[WIP] Upgrade to rails 5.1 #5676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@himdel can you review |
himdel
reviewed
Jun 11, 2019
| @@ -84,8 +84,8 @@ | |||
| expect(infra_topology_service).to receive(:entity_display_type).exactly(2).times.and_call_original | |||
|
|
|||
| icons = infra_topology_service.build_icons | |||
| expect(icons["Openstack"]).to eq(:type => "image", :icon => "/images/svg/vendor-openstack_infra.svg") | |||
| expect(icons["Vmware"]).to eq(:type => "image", :icon => "/images/svg/vendor-vmwarews.svg") | |||
| expect(icons["Openstack"]).to eq(:type => "image", :icon => "/assets/svg/vendor-openstack_infra-3aa93728245a70177256ca7f8bfb3b2bd69eb0b039e414ae3fe48c121226946e.svg") | |||
There was a problem hiding this comment.
the hash will keep changing, we shouldn't hardcode one in specs
himdel
reviewed
Jun 11, 2019
jrafanie
force-pushed
the
rails-5-1
branch
3 times, most recently
from
7362be4 to
1424bd4
Compare
Merged
jrafanie
force-pushed
the
rails-5-1
branch
4 times, most recently
from
895c181 to
2a1b6f3
Compare
|
Checked commit jrafanie@2de99d1 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses ManageIQ/manageiq#18076 to test rails 5.1.
The only remaining work items for UI classic are to fix the 5.0 deprecations on actioncontroller parameters hash with indifferent access methods as it's an actual object in 5.1.
TODO: