Move require/mock from jest.setup to helpers #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
ZitaNemeckova
force-pushed
the
cleanup_angular_jest_test
branch
2 times, most recently
from
3d06291 to
3262950
Compare
ZitaNemeckova
force-pushed
the
cleanup_angular_jest_test
branch
from
3262950 to
98f6300
Compare
ZitaNemeckova
force-pushed
the
cleanup_angular_jest_test
branch
from
98f6300 to
70653fb
Compare
miq-bot
changed the title
|
LGTM, Hint: |
|
Checked commits ZitaNemeckova/manageiq-ui-classic@5ea1eaa~...cb88d9a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Dec 7, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move as much stuff from
jest.setup.jsto helpers. To make work on #4913 easier :)@miq-bot add_label wip, test, technical debt, hammer/no