[WIP] From Jasmine to Jest conversion #4870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
ZitaNemeckova
force-pushed
the
from_jasmine_to_jest
branch
2 times, most recently
from
8cc51d5 to
7fbb879
Compare
Converts fileds_spec and mioq_api_spec from Jasmine to Jest old_js_file_require_helper - sets function from file(s) to global so they can be accessed in Jest specs, requires files
ZitaNemeckova
force-pushed
the
from_jasmine_to_jest
branch
from
7fbb879 to
dde5637
Compare
|
Checked commits ZitaNemeckova/manageiq-ui-classic@068afef~...ebc67bb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot add_label wip
Tools/guides:
https://jestjs.io/docs/en/migration-guide
https://github.com/skovhus/jest-codemods
Run:
bundle exec rake spec:jest
Possible problems:
templateUrl-> convert a component to new js and use HTML fileTODO:
Move all angular stuff from
config/jest.setup.jsto specs that need it. Extra PR #5027Spinnergit cherry-pick 71a3ef4c1567c39aa45c9931f1c4e2c484666898Clean-up issues:
toHaveClassmake our own function or rewrite to use jQuery'shasClass?