GOD's button group can have buttons assign/unassign during create/edit #4913

ZitaNemeckova · 2018-11-14T13:01:06Z

Before:

After:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534529

@miq-bot add_label bug, wip

ZitaNemeckova · 2019-01-09T15:19:50Z

@miq-bot add_label generic objects, automation/automate, hammer/yes, gaprindashvili/yes

ZitaNemeckova · 2019-01-15T16:09:43Z

TODO: - fix includes or use includes from lodash

ZitaNemeckova · 2019-01-16T14:56:42Z

@miq-bot add_label pending core

Depends on ManageIQ/manageiq#18368

himdel · 2019-01-23T11:48:19Z

Depends on ManageIQ/manageiq#18368

Probably shouldn't, given gaprindashvili/yes.
If that core PR ever gets reviewed/merged, we should use it, but probably shouldn't block this one.

ZitaNemeckova · 2019-01-23T11:49:59Z

@himdel I'll remove related commit to that dependency and remove the label. Thanks 👍

ZitaNemeckova · 2019-01-24T09:40:51Z

@miq-bot remove_label wip, pending core

himdel · 2019-07-31T11:34:43Z

app/controllers/generic_object_definition_controller.rb

@@ -148,6 +149,28 @@ def add_button_in_group
    custom_button_set.save!
  end

+  def add_custom_buttons_in_set
+    custom_button_set = CustomButtonSet.find(params[:custom_button_set_id])


find_record_with_rbac

himdel · 2019-07-31T11:36:49Z

app/assets/javascripts/components/generic_object/main-custom-button-group-form.js

@@ -94,7 +117,17 @@ function mainCustomButtonGroupFormController(API, miqService) {
  vm.saveWithAPI = function(method, url, saveObject, saveMsg) {
    miqService.sparkleOn();
    API[method](url, saveObject)
-      .then(miqService.redirectBack.bind(vm, saveMsg, 'success', vm.redirectUrl))
+      // TODO remove once API supports adding/removing buttons from button set


I think this is done in ManageIQ/manageiq#18368

himdel · 2019-07-31T11:37:48Z

app/controllers/generic_object_definition_controller.rb

@@ -148,6 +149,28 @@ def add_button_in_group
    custom_button_set.save!
  end

+  def add_custom_buttons_in_set


(probably not needed - the API now does it too)

himdel · 2019-07-31T11:38:07Z

app/controllers/generic_object_definition_controller.rb

+
+  def custom_buttons_in_set
+    assigned_buttons = if params[:custom_button_set_id].present?
+                         button_set = CustomButtonSet.find(params[:custom_button_set_id])


find_record_with_rbac

himdel · 2019-07-31T11:38:14Z

app/controllers/generic_object_definition_controller.rb

+                       else
+                         []
+                       end
+    generic_object_definition = GenericObjectDefinition.find(params[:generic_object_definition_id])


ZitaNemeckova · 2019-07-31T11:58:53Z

@miq-bot remove_label wip

@romanblanco please review, thanks :)

ZitaNemeckova · 2019-07-31T11:59:37Z

@miq-bot add_label ivanchuk/yes

romanblanco · 2019-07-31T17:32:32Z

@miq-bot add_reviewer @romanblanco

romanblanco

Tested, works 👍

I only have a comment about adding move inside the ManageIQ scope or make it as a library

app/javascript/packs/globals.js

himdel · 2019-08-01T13:03:30Z

app/assets/javascripts/components/generic_object/assign-buttons.js

@@ -0,0 +1,61 @@
+/* globals move */


no longer needed

himdel · 2019-08-01T13:06:39Z

LGTM, merging when green :)

Note: if/when backporting to gaprindashvili or hammer, this will either need an additional commit to update not only button_order but also CustomButtonSet#children, or be backported with ManageIQ/manageiq#18368

miq-bot · 2019-08-01T13:06:54Z

Checked commits ZitaNemeckova/manageiq-ui-classic@831bda5~...03d6c5f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

himdel · 2019-08-02T11:06:49Z

One note - I'm not sure we're ever showing the custom buttons now for generic objects.

I was not able to see any custom button toolbars in GOD > Instances under definition, or in GO > instance detail, or in GO > show_list.

(Neither for buttons added here, or for buttons added in ae customization)

But the button group form seems to be working fine now :)

GOD's button group can have buttons assign/unassign during create/edit (cherry picked from commit 1fc6e61) https://bugzilla.redhat.com/show_bug.cgi?id=1534529

simaishi · 2019-08-02T16:10:39Z

Ivanchuk backport details:

$ git log -1
commit 9ed0f565ff438a2c9b2a549a680fb28bc0cf8a55
Author: Martin Hradil <[email protected]>
Date:   Fri Aug 2 13:04:13 2019 +0200

    Merge pull request #4913 from ZitaNemeckova/god_buttons
    
    GOD's button group can have buttons assign/unassign during create/edit
    
    (cherry picked from commit 1fc6e6197f273a4719af75817f0e0a6be8f627f1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1534529

miq-bot changed the title ~~GOD's button group can have buttons assign/unassign during create/edit~~ [WIP] GOD's button group can have buttons assign/unassign during create/edit Nov 14, 2018

miq-bot added bug wip labels Nov 14, 2018

ZitaNemeckova force-pushed the god_buttons branch from 80feae4 to d141114 Compare November 20, 2018 10:05

ZitaNemeckova mentioned this pull request Dec 3, 2018

Move require/mock from jest.setup to helpers #5027

Merged

ZitaNemeckova mentioned this pull request Jan 9, 2019

Add/Remove CustomButton(s) to CustomButtonSet ManageIQ/manageiq-api#539

Closed

ZitaNemeckova force-pushed the god_buttons branch 3 times, most recently from 1bf1ed5 to 7d58993 Compare January 9, 2019 15:18

miq-bot added automation/automate gaprindashvili/yes generic objects unmergeable labels Jan 9, 2019

ZitaNemeckova force-pushed the god_buttons branch 3 times, most recently from 764408f to 4b8a26a Compare January 11, 2019 09:00

miq-bot removed the unmergeable label Jan 14, 2019

miq-bot added the pending core label Jan 16, 2019

This was referenced Jan 24, 2019

[WIP] Simplify when backend updates CustomButtonSet's children based on cha… #5190

Closed

CustomButtonSet - make sure children follow button_order ManageIQ/manageiq#18368

Merged

ZitaNemeckova force-pushed the god_buttons branch from c91045c to fb34c15 Compare January 24, 2019 09:25

miq-bot changed the title ~~[WIP] GOD's button group can have buttons assign/unassign during create/edit~~ GOD's button group can have buttons assign/unassign during create/edit Jan 24, 2019

miq-bot removed the wip label Jan 24, 2019

himdel reviewed Jul 31, 2019

View reviewed changes

Remove add_custom_buttons_in_set method. Use RBAC.

0f8c328

ZitaNemeckova force-pushed the god_buttons branch from 2333233 to 0f8c328 Compare July 31, 2019 11:57

miq-bot changed the title ~~[WIP] GOD's button group can have buttons assign/unassign during create/edit~~ GOD's button group can have buttons assign/unassign during create/edit Jul 31, 2019

miq-bot added ivanchuk/yes and removed wip labels Jul 31, 2019

miq-bot requested a review from romanblanco July 31, 2019 17:33

romanblanco suggested changes Aug 1, 2019

View reviewed changes

app/javascript/packs/globals.js Outdated Show resolved Hide resolved

himdel reviewed Aug 1, 2019

View reviewed changes

app/assets/javascripts/components/generic_object/assign-buttons.js Outdated

@@ -0,0 +1,61 @@

/* globals move */

Copy link

Contributor

himdel Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer needed

Move mpve function to be on ManageIQ instead of global

03d6c5f

himdel self-assigned this Aug 1, 2019

ZitaNemeckova force-pushed the god_buttons branch from c51abc9 to 03d6c5f Compare August 1, 2019 13:04

himdel added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 2, 2019

himdel merged commit 1fc6e61 into ManageIQ:master Aug 2, 2019

simaishi added ivanchuk/backported and removed ivanchuk/yes labels Aug 2, 2019

Fryguy added hammer/yes? and removed hammer/yes labels Nov 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GOD's button group can have buttons assign/unassign during create/edit #4913

GOD's button group can have buttons assign/unassign during create/edit #4913

ZitaNemeckova commented Nov 14, 2018 •

edited

Loading

ZitaNemeckova commented Jan 9, 2019

ZitaNemeckova commented Jan 15, 2019

ZitaNemeckova commented Jan 16, 2019

himdel commented Jan 23, 2019

ZitaNemeckova commented Jan 23, 2019

ZitaNemeckova commented Jan 24, 2019

himdel Jul 31, 2019

himdel Jul 31, 2019

himdel Jul 31, 2019

himdel Jul 31, 2019

himdel Jul 31, 2019

ZitaNemeckova commented Jul 31, 2019

ZitaNemeckova commented Jul 31, 2019 •

edited

Loading

romanblanco commented Jul 31, 2019

romanblanco left a comment

himdel Aug 1, 2019

himdel commented Aug 1, 2019 •

edited

Loading

miq-bot commented Aug 1, 2019

himdel commented Aug 2, 2019

simaishi commented Aug 2, 2019

GOD's button group can have buttons assign/unassign during create/edit #4913

GOD's button group can have buttons assign/unassign during create/edit #4913

Conversation

ZitaNemeckova commented Nov 14, 2018 • edited Loading

ZitaNemeckova commented Jan 9, 2019

ZitaNemeckova commented Jan 15, 2019

ZitaNemeckova commented Jan 16, 2019

himdel commented Jan 23, 2019

ZitaNemeckova commented Jan 23, 2019

ZitaNemeckova commented Jan 24, 2019

himdel Jul 31, 2019

Choose a reason for hiding this comment

himdel Jul 31, 2019

Choose a reason for hiding this comment

himdel Jul 31, 2019

Choose a reason for hiding this comment

himdel Jul 31, 2019

Choose a reason for hiding this comment

himdel Jul 31, 2019

Choose a reason for hiding this comment

ZitaNemeckova commented Jul 31, 2019

ZitaNemeckova commented Jul 31, 2019 • edited Loading

romanblanco commented Jul 31, 2019

romanblanco left a comment

Choose a reason for hiding this comment

himdel Aug 1, 2019

Choose a reason for hiding this comment

himdel commented Aug 1, 2019 • edited Loading

miq-bot commented Aug 1, 2019

himdel commented Aug 2, 2019

simaishi commented Aug 2, 2019

ZitaNemeckova commented Nov 14, 2018 •

edited

Loading

ZitaNemeckova commented Jul 31, 2019 •

edited

Loading

himdel commented Aug 1, 2019 •

edited

Loading