Moved UI gem dependencies from the main repo #48
Conversation
skateman
force-pushed
the
move-ui-deps
branch
2 times, most recently
from
193347d to
854a2d4
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
@mzazrivec I am pretty sure that this is not pending on the backend, but backend is pending on this as ManageIQ/manageiq#13332 will fail until this is merged. |
|
@Fryguy this should be merged first, could you please take a look? |
| s.add_dependency "angular-ui-bootstrap-rails", "~>0.13.0" | ||
| s.add_dependency "jquery-hotkeys-rails" | ||
| s.add_dependency "sass-rails" | ||
| s.add_dependency "coffee-rails" |
There was a problem hiding this comment.
Minor but can you sort these alphabetically? It makes future diffs and additions simpler.
| require 'patternfly-sass' | ||
| require 'lodash-rails' | ||
| require 'angular-ui-bootstrap-rails' | ||
| require 'jquery-hotkeys-rails' |
There was a problem hiding this comment.
Same about the sorting here unless there is a required ordering for some reason.
There was a problem hiding this comment.
Also do these have to be required from the start? I know they were not marked :require => false in ManageIQ, but do you know why?
There was a problem hiding this comment.
we need them constantly in development and also for asset precompilation in production
The jquery-rjs is included from our fork on GitHub and there is no support for unreleased gems in a gemspec. I also tried to move it to the UI Gemfile, without any success. So until we don't push it to Rubygems.org, it needs to stay in the main repo's Gemfile.
|
Checked commit skateman@820137e with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
The jquery-rjs is included from our fork on GitHub and there is no
support for unreleased gems in a gemspec. I also tried to move it
to the UI Gemfile, without any success. So until we don't push it
to Rubygems.org, it needs to stay in the main repo's Gemfile.
Parent issue:
#1
Merge before:
ManageIQ/manageiq#13332