Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI dependencies from manageiq repo here #1

Closed
martinpovolny opened this issue Dec 22, 2016 · 12 comments
Closed

Move UI dependencies from manageiq repo here #1

martinpovolny opened this issue Dec 22, 2016 · 12 comments

Comments

@martinpovolny
Copy link
Member

WIP: martinpovolny#2

The dependencies should be in the gemspec.

We should also remove the group :ui_dependencies from manageiq/Gemfile.

walteraa pushed a commit to maas-ufcg/manageiq-ui-classic that referenced this issue Feb 9, 2017
…e-tag-error

Fix undefined method service_tag error
skateman referenced this issue in skateman/manageiq-ui-classic Feb 14, 2017
Use decorators for listicon images in Automate/Explorer
@chessbyte
Copy link
Member

Can this be closed now?

@martinpovolny
Copy link
Member Author

I believe, it can. @himdel : Is there something more needed to close this?

@himdel
Copy link
Contributor

himdel commented May 17, 2017

Technically, this is still not done:

group :ui_dependencies do # Added to Bundler.require in config/application.rb
  # Modified gems (forked on Github)
  gem "jquery-rjs",                   "=0.1.1",                       :git => "https://github.com/ManageIQ/jquery-rjs.git", :tag => "v0.1.1-1"
end

(manageiq/Gemfile)

And maybe we should also move haml_lint and scss_lint, possibly capybara (Keenan had a PR I think.), probably also gettext_i18n_rails_js.

So.. the bulk of the work is done, but.. not quite finished yet.

@martinpovolny
Copy link
Member Author

Ok, let's keep a list here so that we can track the progress.

@himdel
Copy link
Contributor

himdel commented May 18, 2017

Agreed..

lucasponce pushed a commit to lucasponce/manageiq-ui-classic that referenced this issue Dec 4, 2017
…-inventor-yv4

Updates operations call to work with inventory V4
@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot
Copy link
Member

miq-bot commented Oct 12, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Oct 12, 2018
@himdel himdel removed the stale label Oct 15, 2018
martinpovolny added a commit that referenced this issue Feb 16, 2019
…nters_1

Fix rubocop warnings in presenters #1
@miq-bot
Copy link
Member

miq-bot commented Apr 22, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Apr 22, 2019
@himdel
Copy link
Contributor

himdel commented Apr 23, 2019

@miq-bot remove_label stale
@miq-bot add_label pinned

^^^

@miq-bot miq-bot added pinned and removed stale labels Apr 23, 2019
pkomanek added a commit to pkomanek/manageiq-ui-classic that referenced this issue May 16, 2019
@jrafanie
Copy link
Member

Related: Removed development dependency for haml_lint here

@mfeifer
Copy link
Contributor

mfeifer commented Dec 13, 2019

cc @jrafanie

@himdel himdel removed their assignment Apr 24, 2020
h-kataria referenced this issue in h-kataria/manageiq-ui-classic Aug 12, 2020
In this PR, Policy Profiles accordion has been moved into it's own explorer, as part of Control explorer split. This is a pre-work for Control explorer de-explorization.
Named policy profile related files and method names to match the model name `miq_policy_set`

ManageIQ#6819
h-kataria referenced this issue in h-kataria/manageiq-ui-classic Aug 24, 2020
In this PR, Policy Profiles accordion has been moved into it's own explorer, as part of Control explorer split. This is a pre-work for Control explorer de-explorization.
Named policy profile related files and method names to match the model name `miq_policy_set`

ManageIQ#6819
himdel pushed a commit that referenced this issue Aug 25, 2020
move listicon_item back into controller
gregoryb-at-ibm pushed a commit to Autosde/manageiq-ui-classic that referenced this issue Sep 6, 2020
skateman pushed a commit that referenced this issue Nov 13, 2020
In this PR, Policy Profiles accordion has been moved into it's own explorer, as part of Control explorer split. This is a pre-work for Control explorer de-explorization.
Named policy profile related files and method names to match the model name `miq_policy_set`

#6819
@gtanzillo
Copy link
Member

This already part of a general effort for pluggitivability

klim-iv pushed a commit to klim-iv/manageiq-ui-classic that referenced this issue Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants