Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved UI gem dependencies from the main repo #48

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Moved UI gem dependencies from the main repo #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/manageiq/ui/classic/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
require 'rails/all'
require 'sass-rails'
require 'coffee-rails'
require 'patternfly-sass'
require 'lodash-rails'
require 'angular-ui-bootstrap-rails'
require 'jquery-hotkeys-rails'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same about the sorting here unless there is a required ordering for some reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do these have to be required from the start? I know they were not marked :require => false in ManageIQ, but do you know why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need them constantly in development and also for asset precompilation in production


module ManageIQ
module UI
Expand Down
7 changes: 7 additions & 0 deletions manageiq-ui-classic.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ Gem::Specification.new do |s|

s.add_dependency "rails", "~> 5.0.0", ">= 5.0.0.1"

s.add_dependency "angular-ui-bootstrap-rails", "~>0.13.0"
s.add_dependency "coffee-rails"
s.add_dependency "jquery-hotkeys-rails"
s.add_dependency "lodash-rails", "~>3.10.0"
s.add_dependency "patternfly-sass", "~> 3.15.0"
s.add_dependency "sass-rails"

s.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
s.add_development_dependency "simplecov"
end