Hide quadicon setting for decorators that inherit the quadicon method #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skateman 'kbrock' is an invalid reviewer, ignoring... |
|
Checked commit skateman@c3b9f65 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quadicon setting sliders in
My Settingsare generated from the decorators based on if they define thequadiconmethod or not. For now we did not allow inheritance among decorators, but our friends at OpenStack need it. This would mess up our UI a little, something like this:To avoid this behavior, only those decorators should be selected from the available ones that explicitly define the
quadiconmethod. This way the UI will not break and also the OpenStack guys will be happy 🍰 ✨/cc @alexander-demichev
@miq-bot add_reviewer @kbrock
@miq-bot add_reviewer @martinpovolny
@miq-bot add_label enhancement, gaprindashvili/no