Add template decorator #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexander-demichev 'skateman' is an invalid reviewer, ignoring... |
skateman
suggested changes
Jun 26, 2018
| @@ -0,0 +1,9 @@ | |||
| class ManageIQ::Providers::Openstack::CloudManager::TemplateDecorator < MiqTemplateDecorator | |||
| def single_quad | |||
There was a problem hiding this comment.
You don't need this line since you're inheriting the method from MiqTemplateDecorator.
| {} | ||
| end | ||
|
|
||
| def size_tooltip |
There was a problem hiding this comment.
I think you should give it a little more meaningful name, like provisioning_volume_size_tooltip but you might come up with something better.
alexander-demicev
force-pushed
the
template-decorator
branch
from
88bc1f6 to
20f863d
Compare
|
Checked commit alexander-demicev@20f863d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@alexander-demichev Could you paste a link to the decorator's PR which should be merged before this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a UI decorator for template. Method
provisioning_volume_size_tooltipreturns message that will be displayed in instance provisioning.