Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide quadicon setting for decorators that inherit the quadicon method #4209

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Hide quadicon setting for decorators that inherit the quadicon method #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/configuration_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def compare_decorator_class(a, b)
# Returns with a hash of allowed quadicons for the current user
def allowed_quadicons
MiqDecorator.descendants # Get all the decorator classes
.select { |klass| klass.method_defined?(:quadicon) } # Select only the decorators that define a quadicon
.select { |klass| klass.instance_methods(false).include?(:quadicon) } # Select only the decorators that define a quadicon
.sort(&method(:compare_decorator_class))
.map do |decorator|
# Get the model name by removing Decorator from the class name
Expand Down