Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce version 2.13.2 of redux-devtools-extension #4174

Merged

Conversation

ZitaNemeckova
Copy link
Contributor

redux-devtools-extension v2.13.3 is broken and bin/webpack isn't working

@himdel opened issue zalmoxisus/redux-devtools-extension#519

Run bin/webpack

Before:

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:159:60 
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:161:61 
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

After:
It works again.

@miq-bot add_label bug, dependencies

@himdel please have a look, thanks :)

@miq-bot
Copy link
Member

miq-bot commented Jun 20, 2018

Checked commit ZitaNemeckova@a013e5d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@himdel
Copy link
Contributor

himdel commented Jun 20, 2018

Looks like we may not need this and 2.13.4 will work - zalmoxisus/redux-devtools-extension#519 (comment)

We'll see what travis says now :)

@ZitaNemeckova
Copy link
Contributor Author

@himdel Well it seems it's not fixed yet - comment and it still fails on master. How much time do you want to give them to fix it?

@himdel himdel merged commit b4ad9a1 into ManageIQ:master Jun 21, 2018
@himdel
Copy link
Contributor

himdel commented Jun 21, 2018

Well, that settles it, merged :)

@himdel himdel self-assigned this Jun 21, 2018
@himdel himdel added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 21, 2018
@himdel himdel added the test label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants