Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13.3: Generic type 'StoreEnhancer' requires 1 type argument(s) #519

Closed
himdel opened this issue Jun 20, 2018 · 6 comments
Closed

2.13.3: Generic type 'StoreEnhancer' requires 1 type argument(s) #519

himdel opened this issue Jun 20, 2018 · 6 comments
Labels

Comments

@himdel
Copy link

himdel commented Jun 20, 2018

With 2.13.3, I'm getting this error during webpack:

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:159:60 
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:161:61 
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

With 2.13.2, this does not happen.

(Looks like 2.13.3 is not mentioned in releases, so not sure where that's coming from...)

@himdel
Copy link
Author

himdel commented Jun 20, 2018

(full diff between non-working yarn.lock and a working one:

7423,7425c7423,7425
< redux-devtools-extension@~2.13.2:
<   version "2.13.3"
<   resolved "https://registry.yarnpkg.com/redux-devtools-extension/-/redux-devtools-extension-2.13.3.tgz#a75e9a7288c4849424974ae41b57ad9762ddb0c8"
---
> [email protected]:
>   version "2.13.2"
>   resolved "https://registry.yarnpkg.com/redux-devtools-extension/-/redux-devtools-extension-2.13.2.tgz#e0f9a8e8dfca7c17be92c7124958a3b94eb2911d"

)

@jhen0409
Copy link
Collaborator

It should be fixed in #520, published as v2.13.4. Feel free to reopen the issue if it still not working.

@zsgalusz
Copy link

Did something go wrong with the publish? v2.13.4 still installs the wrong type definitions...

@himdel
Copy link
Author

himdel commented Jun 21, 2018

Indeed, getting the same error with 2.13.4.

@jhen0409 Seems like I can't re-open the issue, can you please? :)

@jhen0409
Copy link
Collaborator

Sorry I did wrong for publish 🙈, v2.13.5 should be the new type definitions.

@ZitaNemeckova
Copy link

Confirming that v2.13.5 is working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants