Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enforce v2.13.2 of redux-devtools-extension #4177

Conversation

ZitaNemeckova
Copy link
Contributor

Before release of v2.13.5 there was following error:

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:159:60
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:161:61
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

That was fixed by enforcing v2.13.2. But we don't need that change anymore so getting back to original :)

How to reproduce:
Run bin/webpack

@miq-bot add_label gaprindashvili/yes, dependencies

After release of v2.13.5 there's no longer following error:
ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:159:60
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

ERROR in [at-loader] ./node_modules/redux-devtools-extension/index.d.ts:161:61
    TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

So we don't need to stay at v2.13.2 anymore
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label gaprindashvili/yes
@miq-bot add_label gaprindashvili/no

@miq-bot
Copy link
Member

miq-bot commented Jun 21, 2018

Checked commit ZitaNemeckova@dd2c0f1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel himdel merged commit ec3571a into ManageIQ:master Jun 25, 2018
@himdel himdel added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 25, 2018
@himdel himdel self-assigned this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants