Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Policy Details Edit Screen #2045

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Restyle Policy Details Edit Screen #2045

merged 1 commit into from
Aug 30, 2017

Conversation

epwinchell
Copy link
Contributor

This PR standardizes all items into the form-horizontal layout and relabels items for clarity.

Relates to: #1939, #1974 and #2040

Old
screen shot 2017-08-29 at 3 20 11 pm

New
screen shot 2017-08-29 at 3 23 34 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label fine/no, technical debt, formatting/styling

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/038ac330a5ee2fe40292e3a6bbb3c75fd5067cf4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 3 offenses detected

app/views/miq_policy/_policy_details.html.haml

  • ⚠️ - Line 241 - Avoid more than 3 levels of block nesting.
  • ⚠️ - Line 75 - Avoid more than 3 levels of block nesting.
  • ⚠️ - Line 75 - Do not leave space between ! and its argument.

@martinpovolny martinpovolny merged commit b06e8cc into ManageIQ:master Aug 30, 2017
@martinpovolny martinpovolny added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 30, 2017
@epwinchell epwinchell deleted the policy_details_form branch October 25, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants