Restyle Report Filter Screen

[epwinchell]

This PR standardizes all items into the form-horizontal layout and relabels items for clarity.

Relates to: #1939 and #1974

Old

New

[epwinchell]

@miq-bot add_label fine/no, technical debt, formatting/styling

[epwinchell]

@miq-bot assign @dclarizio

[martinpovolny]

@epwinchell : please, take a look at the Rubocop issues. Some seem 1/2 should be easy to fix.

[miq-bot]

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/c23346de431e4292180fa17bc63657fe98002fcf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 7 offenses detected

app/views/report/_form_filter.html.haml

• ⚠️ - Line 22 - Missing curly braces around a hash parameter.
• ⚠️ - Line 22 - Prefer to_s over string interpolation.
• ⚠️ - Line 35 - Avoid more than 3 levels of block nesting.
• ⚠️ - Line 52 - Missing curly braces around a hash parameter.
• ⚠️ - Line 52 - Prefer to_s over string interpolation.
• ⚠️ - Line 58 - Avoid more than 3 levels of block nesting.
• ⚠️ - Line 63 - Avoid more than 3 levels of block nesting.

[epwinchell]

@martinpovolny Done. For the rest, I'm open to suggestions.