Restyle Button Edit Screen

[epwinchell]

This PR is a first pass at cleaning up the styling of the Button Edit Screen. It standardizes all items into the form-horizontal layout and relabels items for clarity.

Follow-up to: #1792

Before

After

[epwinchell]

@miq-bot add_label wip, formatting/styling, technical debt, fine/no

[epwinchell]

cc/ @dclarizio @martinpovolny

[lgalis]

Looks good - verified in the UI.

[martinpovolny]

This is sooo much better than before! Cool!

One thing that I really don't like (on the old and on the new version) is the edit button. I am not sure what patterns we have but I think that it is very unclear that you have to click on it to edit the expression. Can we have a normal button with text + image? Would it be ok according to PF?

Thanks!

[epwinchell]

@martinpovolny said:

One thing that I really don't like (on the old and on the new version) is the edit button. I am not sure what patterns we have but I think that it is very unclear that you have to click on it to edit the expression. Can we have a normal button with text + image? Would it be ok according to PF?

[miq-bot]

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/37d7ad56564f763b974693e4b6196de56cb2bdbf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 2 offenses detected

app/views/layouts/_custom_button_expression.html.haml

• ⚠️ - Line 10 - The = symbol should have one space separating it from code
• ⚠️ - Line 17 - Missing curly braces around a hash parameter.

[epwinchell]

@miq-bot rm_label wip