Make textarea based item selector responsive #1376

epwinchell · 2017-05-17T20:22:16Z

This PR redesigns the textarea-based "item selector" to be fully responsive, including converting png images to font icons.

#1314
https://www.pivotaltracker.com/n/projects/1613907/stories/123185601
https://bugzilla.redhat.com/show_bug.cgi?id=1374761

Old

(full desktop)

(mobile)

New
(full desktop)

(mobile)

epwinchell · 2017-05-17T20:23:03Z

@miq-bot add_label, formatting/styling, bug, enhancement, fine/no, euwe/no, wip

miq-bot · 2017-05-17T20:23:14Z

@epwinchell Cannot apply the following label because they are not recognized:

epwinchell · 2017-05-17T20:23:20Z

@miq-bot assign @dclarizio

epwinchell · 2017-05-17T20:24:17Z

@dclarizio Please test on "edit policy's condition assignment" screen.

epwinchell · 2017-05-17T20:24:53Z

cc @quarckster

epwinchell · 2017-05-17T20:32:57Z

@miq-bot rm_label fine/no, euwe/no

epwinchell · 2017-05-17T20:33:17Z

@miq-bot add_label fine/yes, euwe/yes

epwinchell · 2017-05-24T17:48:51Z

@miq-bot assign @h-kataria

issue: #1314 https://bugzilla.redhat.com/show_bug.cgi?id=1374761

miq-bot · 2017-05-25T21:53:51Z

Checked commits https://github.com/epwinchell/manageiq-ui-classic/compare/26cbaa179419022451dfc406a58ac7b56a4d416c~...9cf0eed7e61e8203607136f2b607c5d0b8ba3acd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
7 files checked, 18 offenses detected

app/views/catalog/_column_lists.html.haml

⚠️ - Line 16 - Use @edit[:new][:available_fields].length.zero? instead of @edit[:new][:available_fields].length == 0.
⚠️ - Line 16 - Use empty? instead of length == 0.
⚠️ - Line 31 - Use @edit[:new][:fields].length.zero? instead of @edit[:new][:fields].length == 0.
⚠️ - Line 31 - Use empty? instead of length == 0.

app/views/miq_policy/_action_options.html.haml

⚠️ - Line 155 - Line is too long. [163/160]

app/views/miq_policy/_alert_profile_details.html.haml

⚠️ - Line 61 - Line is too long. [165/160]

app/views/miq_policy/_event_details.html.haml

⚠️ - Line 147 - Line is too long. [173/160]
⚠️ - Line 189 - Avoid more than 3 levels of block nesting.
⚠️ - Line 190 - The = symbol should have one space separating it from code
⚠️ - Line 52 - Line is too long. [171/160]
⚠️ - Line 93 - Avoid more than 3 levels of block nesting.
⚠️ - Line 94 - The = symbol should have one space separating it from code

app/views/miq_policy/_policy_details.html.haml

⚠️ - Line 95 - Line is too long. [170/160]

app/views/miq_policy/_profile_details.html.haml

⚠️ - Line 45 - Line is too long. [165/160]

app/views/shared/buttons/_column_lists.html.haml

⚠️ - Line 16 - Use @edit[:new][:available_fields].length.zero? instead of @edit[:new][:available_fields].length == 0.
⚠️ - Line 16 - Use empty? instead of length == 0.
⚠️ - Line 31 - Use @edit[:new][:fields].length.zero? instead of @edit[:new][:fields].length == 0.
⚠️ - Line 31 - Use empty? instead of length == 0.

epwinchell · 2017-05-30T13:23:10Z

@miq-bot rm_label wip

epwinchell · 2017-05-30T13:26:57Z

@miq-bot assign @dclarizio

make textarea based item selector responsive (cherry picked from commit c6e3ae2) https://bugzilla.redhat.com/show_bug.cgi?id=1460387

simaishi · 2017-06-09T22:02:11Z

Fine backport details:

$ git log -1
commit cca8238e89105b2481dd3ed8075cd83d00f86952
Author: Dan Clarizio <[email protected]>
Date:   Wed May 31 09:16:32 2017 -0700

    Merge pull request #1376 from epwinchell/responsive_selector
    
    make textarea based item selector responsive
    (cherry picked from commit c6e3ae2c7f0624cc4f45ad33be39ba036f321064)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460387

simaishi · 2017-07-10T19:44:35Z

Backported to Euwe via ManageIQ/manageiq#15322

hstastna · 2018-05-02T12:16:08Z

app/views/shared/buttons/_column_lists.html.haml

+        :style    => "overflow-x: scroll;",
+        :size     => 8,
+        :id       => "available_fields")
+  - if x_active_tree == :ab_tree


Hi Eric @epwinchell , I have a question: why do we have here this condition if x_active_tree == :ab_tree twice? Once in https://github.com/ManageIQ/manageiq-ui-classic/pull/1376/files#diff-fb2d45f8fceb60d60e1267c1d866e824R2, the second time in https://github.com/ManageIQ/manageiq-ui-classic/pull/1376/files#diff-fb2d45f8fceb60d60e1267c1d866e824R12
Is there any reason for that? Thank you! :)

@h-kataria Any ideas?

@epwinchell @hstastna if you look closely at the old/refactored code that was removed had piece of code that was not part of if block
https://github.com/ManageIQ/manageiq-ui-classic/pull/1376/files#diff-fb2d45f8fceb60d60e1267c1d866e824L8

looks like same for the second if block as well https://github.com/ManageIQ/manageiq-ui-classic/pull/1376/files#diff-fb2d45f8fceb60d60e1267c1d866e824L47

miq-bot · 2018-05-02T12:16:37Z

@epwinchell Cannot apply the following label because they are not recognized:

More info: ManageIQ#1376

miq-bot changed the title ~~make textarea based item selector responsive~~ [WIP] make textarea based item selector responsive May 17, 2017

miq-bot added bug enhancement euwe/no formatting/styling wip labels May 17, 2017

miq-bot assigned dclarizio May 17, 2017

miq-bot removed fine/no labels May 17, 2017

miq-bot added euwe/yes labels May 17, 2017

dclarizio requested a review from skateman May 18, 2017 13:32

miq-bot assigned h-kataria and unassigned dclarizio May 24, 2017

epwinchell and others added 2 commits May 25, 2017 15:46

make textarea based item selector responsive

26cbaa1

issue: #1314 https://bugzilla.redhat.com/show_bug.cgi?id=1374761

Moved common buttons code for sequencing forms into a shared partial

9cf0eed

miq-bot changed the title ~~[WIP] make textarea based item selector responsive~~ make textarea based item selector responsive May 30, 2017

miq-bot removed the wip label May 30, 2017

simaishi pushed a commit that referenced this pull request Jun 9, 2017

Merge pull request #1376 from epwinchell/responsive_selector

cca8238

make textarea based item selector responsive (cherry picked from commit c6e3ae2) https://bugzilla.redhat.com/show_bug.cgi?id=1460387

simaishi added fine/backported and removed fine/yes labels Jun 9, 2017

epwinchell mentioned this pull request Jun 22, 2017

Buttons for editing policy conditon assignments have wrong size ManageIQ/manageiq#10621

Closed

simaishi added euwe/backported and removed euwe/yes labels Jul 10, 2017

epwinchell deleted the responsive_selector branch October 25, 2017 18:41

himdel mentioned this pull request Apr 27, 2018

Split flash, navbar and listnav related bits off ApplicationHelper #3873

Merged

hstastna reviewed May 2, 2018

View reviewed changes

miq-bot changed the title ~~make textarea based item selector responsive~~ [WIP] make textarea based item selector responsive May 2, 2018

miq-bot added euwe/no wip and removed fine/no labels May 2, 2018

miq-bot assigned h-kataria and unassigned dclarizio May 2, 2018

miq-bot removed the wip label May 2, 2018

miq-bot assigned dclarizio and unassigned h-kataria May 2, 2018

simaishi removed euwe/yes labels May 2, 2018

dclarizio changed the title ~~[WIP] make textarea based item selector responsive~~ Make textarea based item selector responsive May 2, 2018

hstastna pushed a commit to hstastna/manageiq-ui-classic that referenced this pull request May 4, 2018

Delete unnecessary line of the code in column lists haml

fe1faf8

More info: ManageIQ#1376

hstastna mentioned this pull request May 4, 2018

Delete unnecessary line of the code in column lists haml #3898

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make textarea based item selector responsive #1376

Make textarea based item selector responsive #1376

epwinchell commented May 17, 2017 •

edited

Loading

epwinchell commented May 17, 2017

miq-bot commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 24, 2017

miq-bot commented May 25, 2017

epwinchell commented May 30, 2017

epwinchell commented May 30, 2017

simaishi commented Jun 9, 2017

simaishi commented Jul 10, 2017

hstastna May 2, 2018

epwinchell May 2, 2018

h-kataria May 2, 2018

miq-bot commented May 2, 2018

Make textarea based item selector responsive #1376

Make textarea based item selector responsive #1376

Conversation

epwinchell commented May 17, 2017 • edited Loading

epwinchell commented May 17, 2017

miq-bot commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 17, 2017

epwinchell commented May 24, 2017

miq-bot commented May 25, 2017

epwinchell commented May 30, 2017

epwinchell commented May 30, 2017

simaishi commented Jun 9, 2017

simaishi commented Jul 10, 2017

hstastna May 2, 2018

Choose a reason for hiding this comment

epwinchell May 2, 2018

Choose a reason for hiding this comment

h-kataria May 2, 2018

Choose a reason for hiding this comment

miq-bot commented May 2, 2018

epwinchell commented May 17, 2017 •

edited

Loading