Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] make textarea based item selector responsive #15322

Merged
merged 2 commits into from
Jul 10, 2017
Merged

[EUWE] make textarea based item selector responsive #15322

merged 2 commits into from
Jul 10, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Jun 6, 2017

@epwinchell
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot changed the title [DARGA] make textarea based item selector responsive [WIP] [DARGA] make textarea based item selector responsive Jun 6, 2017
@miq-bot miq-bot added the wip label Jun 6, 2017
@epwinchell epwinchell changed the title [WIP] [DARGA] make textarea based item selector responsive [EUWE] make textarea based item selector responsive Jun 6, 2017
@miq-bot miq-bot removed the wip label Jun 6, 2017
@simaishi simaishi requested a review from dclarizio June 6, 2017 18:20
@epwinchell epwinchell changed the title [EUWE] make textarea based item selector responsive [EUWE] [WIP] make textarea based item selector responsive Jun 7, 2017
@miq-bot miq-bot changed the title [EUWE] [WIP] make textarea based item selector responsive [WIP] [EUWE] [WIP] make textarea based item selector responsive Jun 7, 2017
@miq-bot miq-bot added the wip label Jun 7, 2017
@epwinchell epwinchell changed the title [WIP] [EUWE] [WIP] make textarea based item selector responsive [WIP] [EUWE] make textarea based item selector responsive Jun 8, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 8, 2017

Checked commits https://github.com/epwinchell/manageiq/compare/01dc21827ec4432828aba8308478dc811765d671~...c8c0d26fd229db468f2c17526138959cc229ba6e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
8 files checked, 18 offenses detected

app/views/catalog/_column_lists.html.haml

  • ⚠️ - Line 16 - Use @edit[:new][:available_fields].length.zero? instead of @edit[:new][:available_fields].length == 0.
  • ⚠️ - Line 16 - Use empty? instead of length == 0.
  • ⚠️ - Line 31 - Use @edit[:new][:fields].length.zero? instead of @edit[:new][:fields].length == 0.
  • ⚠️ - Line 31 - Use empty? instead of length == 0.

app/views/miq_policy/_action_options.html.haml

  • ⚠️ - Line 161 - Line is too long. [163/160]

app/views/miq_policy/_alert_profile_details.html.haml

  • ⚠️ - Line 61 - Line is too long. [165/160]

app/views/miq_policy/_event_details.html.haml

  • ⚠️ - Line 147 - Line is too long. [173/160]
  • ⚠️ - Line 189 - Avoid more than 3 levels of block nesting.
  • ⚠️ - Line 190 - The = symbol should have one space separating it from code
  • ⚠️ - Line 52 - Line is too long. [171/160]
  • ⚠️ - Line 93 - Avoid more than 3 levels of block nesting.
  • ⚠️ - Line 94 - The = symbol should have one space separating it from code

app/views/miq_policy/_policy_details.html.haml

  • ⚠️ - Line 95 - Line is too long. [170/160]

app/views/miq_policy/_profile_details.html.haml

  • ⚠️ - Line 45 - Line is too long. [165/160]

app/views/shared/buttons/_column_lists.html.haml

  • ⚠️ - Line 17 - Use @edit[:new][:available_fields].length.zero? instead of @edit[:new][:available_fields].length == 0.
  • ⚠️ - Line 17 - Use empty? instead of length == 0.
  • ⚠️ - Line 32 - Use @edit[:new][:fields].length.zero? instead of @edit[:new][:fields].length == 0.
  • ⚠️ - Line 32 - Use empty? instead of length == 0.

@h-kataria
Copy link
Contributor

verified changes in UI on EUWE

@epwinchell epwinchell changed the title [WIP] [EUWE] make textarea based item selector responsive [EUWE] make textarea based item selector responsive Jun 8, 2017
@epwinchell
Copy link
Contributor Author

@miq-bot rm_label wip

@miq-bot miq-bot removed the wip label Jun 8, 2017
@simaishi
Copy link
Contributor

@epwinchell please resolve the conflict.

@miq-bot
Copy link
Member

miq-bot commented Jul 1, 2017

This pull request is not mergeable. Please rebase and repush.

@epwinchell
Copy link
Contributor Author

@simaishi Rebased

@simaishi simaishi merged commit cbb1d27 into ManageIQ:euwe Jul 10, 2017
@simaishi simaishi added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 10, 2017
@epwinchell epwinchell deleted the responsive_item_selectors branch July 10, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants