Split flash, navbar and listnav related bits off ApplicationHelper #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
changed the title
to move code to
…nship_link, multiple_relationship_link, valid_html_id, li_link, build_link_text, link_to_with_icon, render_listnav_filename
… section_nav_class
|
@miq-bot remove_label wip @martinpovolny This should be ready.. |
miq-bot
changed the title
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/74cf5a8219851ca83b4ae0cb101065990d03e543~...c293b554eb21f24453e6f08820065cc8f2259459 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/application_helper/listnav.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a straightforward move of a bunch of methods to 3 new ApplicationHelper concerns:
ApplicationHelper::Flash-flash_to_session,render_flash_msg?,javascript_flashApplicationHelper::Listnav-miq_accordion_panel,single_relationship_link,multiple_relationship_link,valid_html_id,li_link,build_link_text,link_to_with_icon,render_listnav_filenameApplicationHelper::Navbar-item_nav_class,section_nav_class_iframe,section_nav_classAnd removes a dead
ApplicationHelpermethod -link_image_if, last used before #1376.(The idea is to make the application helper rating a bit better, and maybe to clean up any issues CC finds in the new files. => wip)