Add a STI disabled spec #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, one issue I see is that this uses the current schema to check "old" migrations, which is invalid. You need to use the schema at the time of the migration to determine if the inheritance disablement is necessary. |
bdunne
force-pushed
the
type_disabled_spec
branch
from
efafe43 to
ed03d47
Compare
|
@Fryguy Updated, please take a look |
Fryguy
reviewed
Aug 9, 2018
spec/support/migration_helper.rb
Outdated
| @@ -15,6 +15,19 @@ def migration_context(direction, &block) | |||
|
|
|||
| it("with empty tables") { migrate } | |||
|
|
|||
| it "STI is disabled for all involved ActiveRecord::Base descendants" do | |||
| classes = ActiveRecord::Base.descendants.select { |klass| klass.namespace.first == described_class.to_s }.compact | |||
There was a problem hiding this comment.
Might be better to flip this around to something like
described_class.constants.select { |c| c < ActiveRecord::Base }
bdunne
force-pushed
the
type_disabled_spec
branch
from
ed03d47 to
f69f8b6
Compare
|
Checked commits bdunne/manageiq-schema@8aaeae5~...f69f8b6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this as an automated code review to address #4 (comment)
Also fixing the current failures