Ensure id and *_id columns are bigint

[bdunne]

Based on changes in #245

Adding this as an automated code review to address #4 (comment)

[Fryguy]

Minor, but maybe make this a Set, since we are doing continual lookups

[Fryguy]

As discussed, the tests fail and tell the user to remove the column from the exclusion list when they fix it.

Also, the exclusions_list should be a constant like in the other PR>

[miq-bot]

Checked commit bdunne@971e9b5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[Fryguy]

Moving forward, perhaps this should move into a DatabaseHelper method...

def DatabaseHelper.each_table
  ActiveRecord::Base.connection.tables.each do |table|
    next if ManageIQ::Schema::SYSTEM_TABLES.include?(table)
    yield table
  end
end

def DatabaseHelper.each_column
  each_table do |table|
    columns_for_table(table).each do |column|
      yield table, column
    end
  end
end

Then caller just does

DatabaseHelper.each_column do |table, column|
   ...
end