Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a spec that verifies that stub models have inheritance check #114

Closed
Fryguy opened this issue Oct 27, 2017 · 2 comments
Closed

Add a spec that verifies that stub models have inheritance check #114

Fryguy opened this issue Oct 27, 2017 · 2 comments

Comments

@Fryguy
Copy link
Member

Fryguy commented Oct 27, 2017

I'm not sure how, but it might help data migration authors if the stub models they create were verified as to whether or not they require the

self.inheritance_column = :_type_disabled # disable STI

We might be able to do it by creating a separate test as part of

context "##{direction}", :migrations => direction do
before(:all) do
prepare_migrate
end
around do |example|
Rails.logger.debug("============================================================")
clearing_caches(&example)
end
it("with empty tables") { migrate }
instance_eval(&block)

@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@bdunne
Copy link
Member

bdunne commented Aug 13, 2018

Fixed by: #245

@bdunne bdunne closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants