Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted DDF schema and validation for creating new providers #509

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Adjusted DDF schema and validation for creating new providers #509

merged 2 commits into from
Jul 30, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 3, 2020 •
edited
Loading

Before:
Screenshot from 2020-07-03 11-23-36

After:
Screenshot from 2020-07-03 11-23-11

Depends on: #508
Parent issue: ManageIQ/manageiq#18818

@skateman skateman mentioned this pull request Jul 3, 2020
Merged
4 tasks
@miq-bot miq-bot added the wip label Jul 3, 2020
@agrare agrare mentioned this pull request Jul 30, 2020
Closed
@miq-bot
Copy link
Member

miq-bot commented Jul 30, 2020

Checked commits skateman/manageiq-providers-ovirt@fe8f1e5~...dcef420 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

agrare
agrare approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I'll merge when you take it out of WIP

@skateman skateman changed the title [WIP] Adjusted DDF schema and validation for creating new providers Adjusted DDF schema and validation for creating new providers Jul 30, 2020
@miq-bot miq-bot removed the wip label Jul 30, 2020
@skateman
Copy link
Member Author

@agrare good to go

@agrare agrare self-assigned this Jul 30, 2020
@agrare agrare merged commit 3608b19 into ManageIQ:master Jul 30, 2020
@skateman skateman deleted the adjust-ddf-schema branch July 30, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@borod108 borod108 Awaiting requested review from borod108

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gekorob gekorob Awaiting requested review from gekorob

@mwperina mwperina Awaiting requested review from mwperina

Assignees

@agrare agrare

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skateman @miq-bot @agrare