Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing asynchronous context-free credential validation for DDF #508

Closed
skateman opened this issue Jul 3, 2020 · 1 comment
Closed

Missing asynchronous context-free credential validation for DDF #508

skateman opened this issue Jul 3, 2020 · 1 comment
Assignees
Labels

Comments

@skateman
Copy link
Member

skateman commented Jul 3, 2020

There's no self.verify_credentials for the add provider form, also the already existing validation operates with DB models, so it's basically the same problem as in ManageIQ/manageiq-providers-kubernetes#387 but here for the default and the metrics endpoint.

@miq-bot assign @agrare
Parent issue: ManageIQ/manageiq#18818

@agrare
Copy link
Member

agrare commented Jul 30, 2020

Hey @skateman actually there is one it is just in InfraManager::ApiIntegrations. I had to update it to match what you have in #509 so I'll push the changes to your branch but verification and adding the provider works, going to close this

@agrare agrare closed this as completed Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants