Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace angular-based infra provider forms with the DDF component #7181

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 3, 2020

Replacing the infra provider forms with the DDF implementation, the following schemas have been converted:

The form is still in a dual mode, so it's easy to compare the old forms with the new ones...

Parent issue: ManageIQ/manageiq#18818

@skateman skateman requested review from himdel and h-kataria July 3, 2020 08:35
@skateman skateman changed the title Replace angular-based infra provider forms with the DDF component [WIP] Replace angular-based infra provider forms with the DDF component Jul 3, 2020
@miq-bot miq-bot added the wip label Jul 3, 2020
@skateman skateman changed the title [WIP] Replace angular-based infra provider forms with the DDF component Replace angular-based infra provider forms with the DDF component Jul 30, 2020
@skateman
Copy link
Member Author

@h-kataria this si ready for a review, might need a rebase and bin/update

@miq-bot miq-bot removed the wip label Jul 30, 2020
@skateman skateman force-pushed the infra-provider-ddf branch from c7566d5 to e143250 Compare July 31, 2020 16:04
@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2020

Checked commit skateman@e143250 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.8-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@h-kataria
Copy link
Contributor

h-kataria commented Jul 31, 2020

verified in UI.
@skateman Noticed 2 differences from old version of the form in flash messages.

  • Flash message is missing when pressing Reset button on edit Provider form, need to open a separate issue to make it consistent among all DDF forms.
  • When pressing Cancel button on edit form, record name/display name is missing from the flash message

@h-kataria
Copy link
Contributor

verified in UI.
@skateman Noticed 2 differences from old version of the form in flash messages.

* Flash message is missing when pressing Reset button on edit Provider form, need to open a separate issue to make it consistent among all DDF forms.

* When pressing Cancel button on edit form, record name/display name is missing from the flash message

opened #7244

@h-kataria h-kataria self-assigned this Jul 31, 2020
@h-kataria h-kataria merged commit 4b9c7e6 into ManageIQ:master Jul 31, 2020
@skateman skateman deleted the infra-provider-ddf branch July 31, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants