Update disconnection test to understand soft delete #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moolitayer @zakiva @simon3z this makes Travis green 👷 🍏 @miq-bot add-label test |
|
Checked commit cben@a974d9e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I see there is discussion on ManageIQ/manageiq#15251 whether it should have been merged; |
|
Ping @moolitayer @simon3z tiny fix for red master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnect tests added in #44 were expecting ems_id to become nil,
which doesn't happen after soft delete ManageIQ/manageiq#15251.
Fixed by asking
.archived?instead.