Refresher_spec: Add deletions tests #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cben
approved these changes
Jun 20, 2017
| expect(ContainerDefinition.where(:deleted_on => nil).count).to eq(7) | ||
| end | ||
|
|
||
| it "removes the deleted objects from the DB" do |
There was a problem hiding this comment.
I'd add here a comment with short overview of the deletions, to give some context to the reader.
(deleted whole "my-project-0", many (all?) entities in "my-project-1", a pod and a route label in "my-project-2" — something like that)
Risks getting out sync. Your call.
There was a problem hiding this comment.
@zakiva waiting for this before merging.
There was a problem hiding this comment.
Yes, just copied them here |
zakiva
force-pushed
the
deletions_tests
branch
3 times, most recently
from
8e8fb9f to
12b4c7b
Compare
|
Checked commit zakiva@12b4c7b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted k8s entities tests from ManageIQ/manageiq-providers-openshift#18
@simon3z @cben @moolitayer Please review