Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refresher_spec for soft delete #31

Merged

Conversation

cben
Copy link
Contributor

@cben cben commented Jul 9, 2017

Following ManageIQ/manageiq#15251,
similar to
ManageIQ/manageiq-providers-kubernetes#55

@miq-bot add-label test
@simon3z @moolitayer @zakiva please review, tiny fix for red master

@cben cben mentioned this pull request Jul 9, 2017
1 task
@miq-bot miq-bot added the test label Jul 9, 2017
@cben cben force-pushed the disconnect-test-ask-archived-method branch from d1f5e52 to 3721a6d Compare July 9, 2017 13:18
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

did some of this in #29. This one has some additional changes so we will go with this one

@moolitayer
Copy link

Let me know when Travis is green @cben

@cben
Copy link
Contributor Author

cben commented Jul 9, 2017

is green.

@moolitayer moolitayer merged commit db3307d into ManageIQ:master Jul 9, 2017
@moolitayer moolitayer added this to the Sprint 64 Ending Jul 10, 2017 milestone Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants