Fog google upgrade (to 1.3.3)

[tumido]

Upgrade fog-google to the latest release (1.3.3).

• Update dependencies (Update dependencies to match new fog-google manageiq#17258, Update addressable gem version to 2.5.0 azure-armrest#366)
• Update cloud refresh parser
• Update network refresh parser (would require Listing all subnetworks symbol key fog/fog-google#321, fixed by bypassing fog-google and using google ruby client instead)
• Upgrade metrics to the new API
• Update event collection and parsing (fog-google bypassed, since we don't need Base64 decode which breaks everything...)
• Update operations (no changes needed)
• Update provisioning (fog-google bug fixed, removing workaround)
• Record new VCRs
• Update testsuite for refresher
• Add testsuite for events
• Update testsuite for metrics

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1511099
Depends on: ManageIQ/manageiq#17258
Depends on: ManageIQ/azure-armrest#366

Most of the tasks mentioned above have rather a checklist character. It doesn't necessary mean everything has to change. I just need to go through it and correct any misbehavior...

[tumido]

@miq-bot add_label wip

[tumido]

@miq-bot add_label pending core

[tumido]

Once someone is reviewing this, please look closely on the event collection and parsing. I've decided to bypass the fog-google there, since it butchers the events when it tries to decode the event data from Base64. Despite the documentation says the events should be encoded in Base64, in reality for me they are showing as a plaintext. The API wasn't changed on Google side, so I don't understand what's happening. What also confuses me - we used to parse the events as StructPayload, now I see only JsonPayload.

In the end this is a working solution, which removes one dependency on fog-google and calls the google-api-client directly.

Maybe I'm just getting different events, I don't know...

[tumido]

@miq-bot remove_label wip
All is done, ready for review! 🎉 🎆

[agrare]

Rest of the comments can be addressed in a follow-up PR, LGTM @bronaghs

[agrare]

🎉

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 776f7c16e7ba878fbc63a6a122aeb5a6a0c0f1f9
Author: Bronagh Sorota <[email protected]>
Date:   Thu May 31 14:54:04 2018 -0400

    Merge pull request #54 from tumido/fog_google_upgrade
    
    Fog google upgrade (to 1.3.3)
    (cherry picked from commit ec8b909962ba9f6e6d9954fa1eff64c3fc7e3405)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1585821

[simaishi]

@tumido ManageIQ/manageiq#17258 is listed as dependency, but that's not marked as fine/yes. I assume that's also needed? All other checklist have no PRs associated, so maybe nothing to do for Fine branch there... but not sure. Fine branch already uses azure-armrest which includes ManageIQ/azure-armrest#366, so that's taken care of.

Also this PR conflicts on cherry-pick. Please create a separate PR for Fine branch.

[tumido]

@simaishi can you please guide me how to do that? It seems there's no fine branch in https://github.com/ManageIQ/manageiq-providers-google

[simaishi]

@tumido Please create a PR in manageiq repo.

[simaishi]

Backported to Fine via ManageIQ/manageiq#17914