Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addressable gem version to 2.5.0 #366

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

tumido
Copy link
Member

@tumido tumido commented Apr 6, 2018

In order to upgrade fog-google in google provider, it is required to upgrade the addressable in azure as well.

Dependency chain:

Related: ManageIQ/manageiq-providers-google#54

@tumido
Copy link
Member Author

tumido commented Apr 6, 2018

@miq-bot add_label wip

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2018

Checked commit tumido@54692f5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@djberg96
Copy link
Collaborator

@tumido I don't suppose you have a quick summary of the changes, do you?

@tumido
Copy link
Member Author

tumido commented Apr 10, 2018

@djberg96, well... I have to rely on the changelog addressable provides.

Cite:

# Addressable 2.5.2
- better support for frozen string literals
- fixed bug w/ uppercase characters in scheme
- IDNA errors w/ emoji URLs
- compatibility w/ public_suffix 3.x

# Addressable 2.5.1
- allow unicode normalization to be disabled for URI Template expansion
- removed duplicate test

# Addressable 2.5.0
- dropping support for Ruby 1.9
- adding support for Ruby 2.4 preview
- add support for public suffixes and tld; first runtime dependency
- hostname escaping should match RFC; underscores in hostnames no longer escaped
- paths beginning with // and missing an authority are now considered invalid
- validation now also takes place after setting a path
- handle backslashes in authority more like a browser for `heuristic_parse`
- unescaped backslashes in host now raise an `InvalidURIError`
- `merge!`, `join!`, `omit!` and `normalize!` don't disable deferred validation
- `heuristic_parse` now trims whitespace before parsing
- host parts longer than 63 bytes will be ignored and not passed to libidn
- normalized values always encoded as UTF-8

Branch compare:
sporkmonger/addressable@addressable-2.4.0...master

I hope that's enough for an educated guess of what's been changed, lol...

@djberg96
Copy link
Collaborator

@tumido I'm ok with this. Do you want to un-wip it?

@tumido tumido changed the title [WIP] Update addressable gem version to 2.5.0 Update addressable gem version to 2.5.0 Apr 10, 2018
@tumido
Copy link
Member Author

tumido commented Apr 10, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Apr 10, 2018
@djberg96 djberg96 self-requested a review April 10, 2018 14:17
@djberg96
Copy link
Collaborator

LGTM 👍

@djberg96 djberg96 merged commit 225f82c into ManageIQ:master Apr 10, 2018
@tumido tumido deleted the update_addressable branch June 26, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants