Follow up on #54 "Fog google upgrade (to 1.3.3)" code cleanup #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
commented
Jun 1, 2018
| @@ -180,7 +180,7 @@ def get_cloud_networks | |||
|
|
|||
| def subnetworks | |||
| unless @subnetworks | |||
| @subnetworks = @connection.list_aggregated_subnetworks.to_h[:items].flat_map { |_, v| v[:subnetworks] } | |||
| @subnetworks = @connection.list_aggregated_subnetworks.to_h[:items].values.flat_map { |v| v[:subnetworks] } | |||
There was a problem hiding this comment.
@agrare, I couldn't do here what you've suggested. The :subnetworks is not an method but a key in Hash so we can't be calling it like:
@connection.list_aggregated_subnetworks.to_h[:items].values.flat_map(&:subnetworks)I've tried also this:
@connection.list_aggregated_subnetworks.to_h[:items].values.pluck(:subnetworks).flattenDespite it's being a bit better readable, it performs about twice slower than the flat_map version (due to the flatten). So I've left the flat_map here.
There was a problem hiding this comment.
👍 it was the .values instead of { |_, v| that I most cared about
|
Checked commit tumido@524bc14 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
added a commit
that referenced
this pull request
Jun 4, 2018
Follow up on #54 "Fog google upgrade (to 1.3.3)" code cleanup
|
Fiine backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's follow up on #54 and incorporate some changes @agrare suggested.
Make the code neater and faster again!