Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update VCR cassettes with EBS parser #122

Closed

Conversation

gberginc
Copy link
Contributor

@gberginc gberginc commented Jan 26, 2017

This is a temporary PR that is to be used to get the updated VCRs for the EBS storage manager.

@miq-bot add_label wip

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2017

@gberginc Cannot apply the following label because they are not recognized: wip

@gberginc
Copy link
Contributor Author

@miq-bot assign @Ladas

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2017

Checked commit gberginc@5beb8df with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍪

@gberginc
Copy link
Contributor Author

@miq-bot add_label wip

@chargio
Copy link

chargio commented Jan 31, 2017

Hi @Ladas can we merge this? I think that there are two other PR depending on this.

Thanks,
Sergio

@gberginc
Copy link
Contributor Author

@sergio-ocon I didn't plan to merge this one, because it will break the specs.

I marked it WIP because we discussed with @Ladas it would be best if I try to extend the specs for EBS based on his AWS account. I already have some other tests so that I can work on the provider. Hopefully, I'll then just be able to migrate those specs.

@Ladas
Copy link
Contributor

Ladas commented Jan 31, 2017

@gberginc also, I am thinking that I will prepare a set of CloudFormation templates, that would deploy all kinds of data combinations we would need to test. Hopefully packed into one big template. With a little script around that, it should be a nice way to turn any AWS account into a VCR env. Also will be easier to get rid of the data after.

Maybe if you would create CloudFormation template for Vms with Volumes, with the combinations you need to test. I could just deploy that in the VCR AWS Account and we would be testing the same data and crosslinks?

@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

This pull request is not mergeable. Please rebase and repush.

@Ladas
Copy link
Contributor

Ladas commented Mar 23, 2017

👍 right, I've already sent these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants