Parse the name of EBS volume or snapshot #121
Conversation
gberginc
force-pushed
the
parse_volume_snapshot_name
branch
from
dde57d2 to
93a2732
Compare
|
@miq-bot add_label euwe/no, enhancement |
| def get_from_tags(resource, item) | ||
| (resource['tags'] || []).detect { |tag, _| tag['key'].downcase == item.to_s.downcase }.try(:[], 'value') | ||
| end | ||
|
|
There was a problem hiding this comment.
Once this PR is merged, the get_from_tags method will be overridden in 3 different RefreshParserInventoryObject subclasses (NetworkManager, CloudManager, StorageManager) - each one identical.
For the record, as the comment on line 62 indicates, the above implementation will replace the current version in the RefreshHelperMethods module when the RefreshParser class becomes obsolete.
There was a problem hiding this comment.
It hurt very much copying it once more. I was thinking about using a different name. For example, I thought about renaming the existing get_from_tags in the helpers module and using this one instead, but just couldn't find a proper name (get_from_tags_legacy or get_from_tags_refresh_parser didn't sound ok to me).
Any idea?
There was a problem hiding this comment.
@gberginc - Haha I completely know what you mean. If the RefreshParser wasn't on the cusp of being deprecated i would like to see it addressed, but refactoring this disrupts a number of classes and I'm not sure it is worth the effort when it will be addressed properly for the G release.
There was a problem hiding this comment.
Yeah it sucks, but it should be an easy cleanup later :-)
gberginc
force-pushed
the
parse_volume_snapshot_name
branch
from
93a2732 to
4257205
Compare
Name is defined as a tag and can be optional. Patch uses the id of the volume/snapshot if name is not given. Signed-off-by: Gregor Berginc <[email protected]>
gberginc
force-pushed
the
parse_volume_snapshot_name
branch
from
4257205 to
774e479
Compare
|
Checked commit gberginc@774e479 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gberginc - great, thanks. |
|
@bronaghs is this safe to merge or should we wait for the VCR as well? |
|
@gberginc - A separate PR using the VCR specs is fine. |
Name is defined as a tag and can be optional. Patch uses the id of
the volume/snapshot if name is not given.