Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue EBS storage refresh after cloud inventory is saved #120

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

gberginc
Copy link
Contributor

@gberginc gberginc commented Jan 26, 2017

While parsing volumes immediately after new AWS manager is created, EBS
manager failed to get proper links to availability zones, because it was
parsing data in parallel to the cloud manager. This patch queues the EBS
storage manager parse in the same way as the network manager, i.e.
immediately after the cloud inventory is saved, EBS refreshes the data
once more.

@miq-bot assign @Ladas

@Ladas I assigned you because there is a todo for you and would like to check if this is still valid way to go.

@Ladas
Copy link
Contributor

Ladas commented Jan 26, 2017

@gberginc yes, this will be the default way of refresh. Full refresh is big and slow, but it's very easy to keep consistent data.

@Ladas
Copy link
Contributor

Ladas commented Jan 26, 2017

@gberginc it will be enough to increase the MiqQueue count in specs, you are adding a refresh to a Queue, so it has risen +1

The VCR update will be needed when you will add the storage refresh to the spec.

While parsing volumes immediately after new AWS manager is created, EBS
manager failed to get proper links to availability zones, because it was
parsing data in parallel to the cloud manager. This patch queues the EBS
storage manager parse in the same way as the network manager, i.e.
immediately after the cloud inventory is saved, EBS refreshes the data
once more.

Signed-off-by: Gregor Berginc <[email protected]>
@gberginc gberginc force-pushed the queue_ebs_refresh_after_cloud branch from 01f9136 to c6e88e5 Compare January 26, 2017 21:25
@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2017

Checked commit gberginc@c6e88e5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

@gberginc
Copy link
Contributor Author

@Ladas I've updated the queue counts so it should pass (hopefully; while trying to run the test locally, I received authentication errors).

With respect to VCR update, I created a WIP PR that adds corresponding EBS manager refreshes. Could you record a new cassette and send it to me so that I can update the specific tests?

@gberginc
Copy link
Contributor Author

@miq-bot add_label euwe/no, enhancement

@Ladas
Copy link
Contributor

Ladas commented Jan 26, 2017

great 👍, will send you the VCR tomorrow

@Ladas Ladas merged commit c713660 into ManageIQ:master Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants