Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return picture content on create #292

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Do not return picture content on create #292

merged 2 commits into from
Jan 18, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Jan 18, 2018 •
edited
Loading

Do not return picture content on create, which will resolve broken specs introduced by ManageIQ/manageiq#16810

Since we are not returning picture content, this now returns image_href on create, which is how images can be returned.

@miq-bot add_label bug, gaprindashvili/yes

@jntullo
Copy link
Author

jntullo commented Jan 18, 2018

@miq-bot assign @abellotti

@bdunne
Copy link
Member

bdunne commented Jan 18, 2018

Do we also need something for retrieving or updating the record?

@jntullo
Copy link
Author

jntullo commented Jan 18, 2018

@bdunne right now, by default, retrieving doesn't return content, so it works as expected. And we don't allow updates of pictures

@NickLaMuro NickLaMuro mentioned this pull request Jan 18, 2018
Merged
Return extension so that content is not returned by default and updat…
a792c7d 
…e specs to properly ensure that pictures get returned successfully without their content
@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2018

Checked commits jntullo/manageiq-api@1927b3b~...a792c7d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit ea3b327 into ManageIQ:master Jan 18, 2018
@Fryguy Fryguy added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 18, 2018
@Fryguy Fryguy added the blocker label Jan 18, 2018
@Fryguy Fryguy assigned Fryguy and unassigned abellotti Jan 18, 2018
simaishi pushed a commit that referenced this pull request Jan 18, 2018
@Fryguy @simaishi
Merge pull request #292 from jntullo/picture_content_create
06ed58f 
Do not return picture content on create
(cherry picked from commit ea3b327)

https://bugzilla.redhat.com/show_bug.cgi?id=1536046
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 06ed58fba03e40b0f4afaa02ca8b2daf1e786dcf
Author: Jason Frey <[email protected]>
Date:   Thu Jan 18 15:55:33 2018 -0500

    Merge pull request #292 from jntullo/picture_content_create
    
    Do not return picture content on create
    (cherry picked from commit ea3b327503f144d37ee29000d8a61a6ff53633b3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1536046

@jntullo jntullo mentioned this pull request Jan 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jntullo @bdunne @miq-bot @simaishi @Fryguy @abellotti