Fix picture fetching as an attribute

[jntullo]

Fetching a picture as an attribute is causing the same error that we saw #292, where it returns:

"kind": "internal_server_error",
"message": "\"\\x89\" from ASCII-8BIT to UTF-8",
"klass": "Encoding::UndefinedConversionError"

due to the changes in picture content.

This change creates a picture mixin to both format the way a picture object will now be returned, as well as provide a fetch method for collections with picture attributes.

Note, that I only added the module to collections that we were testing picture attribute selection on. We may need to add it to more in the future, or consider other options such as a picture serializer.

@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @abellotti

[jntullo]

cc: @himdel

[Fryguy]

Now you know I HAVE to see what this picture is cc @bdunne

[jntullo]

@Fryguy let me know, I added this in a while ago and forgot 😆 maybe a heart?

[Fryguy]

awww..just a blank square :/

[imtayadeway]

I *think* IIRC this is a single pixel - maybe the smallest possible image?

[miq-bot]

Checked commit jntullo@026a716 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 0 offenses detected
Everything looks fine. 🏆

[himdel]

Thanks, confirming this fixes my /api/service_templates?expand=resources&attributes=picture issue :)

Heads up: SUI's Service Catalog section isn't accessible without this fix (assuming any pictures I guess), so possibly this should be a blocker.

[jntullo]

@miq-bot add_label blocker

[abellotti]

LGTM!! Thanks @jntullo for fixing this ...

[abellotti]

ping @Fryguy @imtayadeway please review/ ✅ when you get a chance. Thanks!!

[imtayadeway]

I'm good with this. The only concern I have is the duplicated knowledge of which things can have a picture - if that changes on the backend will someone remember to update this too? I'm wondering if the mixin should be included in the base controller?

[imtayadeway]

I need to get that serializers PR finished ;)

[jntullo]

@imtayadeway yes please! 😛

[jntullo]

@imtayadeway Yeah, that was a concern I had as well. Even if we include the module in the base controller, it is still looking for methods with the resource name, ie fetch_service_picture, which will require a change. I think by including the module in the individual controllers, it is a bit more clear for now about where things are coming from. I was going to refactor this to work for any resource that may have a picture, but felt this was a bit out of scope of the fix for now (but I do want to get back to refactoring it)

[abellotti]

Looks like this is good to go. Thanks @jntullo for fixing this 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit a5dfea6a4fc39fdaa86f9b4927e5adb1527cacd0
Author: Alberto Bellotti <[email protected]>
Date:   Tue Jan 23 09:13:46 2018 -0500

    Merge pull request #294 from jntullo/picture_fetch_method
    
    Fix picture fetching as an attribute
    (cherry picked from commit 99a3b6303e6674840b9114988dfeb7d59bc4731a)