Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picture content is moving to the pictures table. #16810

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Picture content is moving to the pictures table. #16810

merged 1 commit into from
Jan 17, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jan 11, 2018

  • No longer need the binary_blob logic here
  • No longer need to test logic for #extension setting

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1532286

To be merged with ManageIQ/manageiq-schema#153

@bdunne
Picture content is moving to the pictures table.
5bcd0d1 
- No longer need the binary_blob logic here
- No longer need to test logic for #extension setting

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1532286
@bdunne bdunne requested a review from Fryguy January 11, 2018 21:58
@bdunne bdunne mentioned this pull request Jan 11, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2018

Checked commit bdunne@5bcd0d1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy closed this Jan 17, 2018
@Fryguy Fryguy reopened this Jan 17, 2018
@Fryguy
Copy link
Member

Fryguy commented Jan 17, 2018

Merged the schema, so bounced this PR.

@gtanzillo gtanzillo added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 17, 2018
@gtanzillo gtanzillo merged commit beebb2d into ManageIQ:master Jan 17, 2018
@bdunne bdunne deleted the move_pictures branch January 17, 2018 21:59
simaishi pushed a commit that referenced this pull request Jan 18, 2018
@gtanzillo @simaishi
Merge pull request #16810 from bdunne/move_pictures
23dcbbc 
Picture content is moving to the pictures table.
(cherry picked from commit beebb2d)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536046
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 23dcbbc737c26d5322d539ef56528f4a4b436f65
Author: Gregg Tanzillo <[email protected]>
Date:   Wed Jan 17 16:53:40 2018 -0500

    Merge pull request #16810 from bdunne/move_pictures
    
    Picture content is moving to the pictures table.
    (cherry picked from commit beebb2daa65182d9f087df786eca130f4ca65e34)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536046

@jntullo jntullo mentioned this pull request Jan 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

@Fryguy Fryguy Fryguy approved these changes

Assignees

@gtanzillo gtanzillo

Labels
blocker core enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bdunne @miq-bot @Fryguy @simaishi @gtanzillo @chessbyte