This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR][NOTEST]Vm name enhancement #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedark3
force-pushed
the
vm_name_enhancement
branch
2 times, most recently
from
c5e243e
to
efac4e0
Compare
kedark3
force-pushed
the
vm_name_enhancement
branch
from
efac4e0
to
6bdb1ba
Compare
|
I detected some fixture changes in commit 6bdb1ba The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
ganeshhubale
approved these changes
Jan 17, 2020
| policy = appliance.collections.policies.create( | ||
| VMControlPolicy, | ||
| fauxfactory.gen_alpha(15, start="policy_"), | ||
| scope="fill_field(VM and Instance : Name, INCLUDES, {})".format(new_vm.name), | ||
| scope="fill_field(VM and Instance : Name, INCLUDES, {})".format(create_vm.name), | ||
| ) |
There was a problem hiding this comment.
optional: I would have used fstring here
john-dupuy
approved these changes
Jan 17, 2020
john-dupuy
changed the title
|
@john-dupuy agree |
jawatts
approved these changes
Jan 17, 2020
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
create_vmfixture.NO PRT RUN. Will run in Jenkins.