Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR][NOTEST]Vm name enhancement 2 #9851

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[1LP][RFR][NOTEST]Vm name enhancement 2 #9851

merged 1 commit into from
Jan 17, 2020

Conversation

kedark3
Copy link
Contributor

@kedark3 kedark3 commented Jan 16, 2020

Purpose or Intent

  • Enhancement to replace one off fixtures and create_on_provider calls with create_vm fixture.

NO PRT RUN. Will run in Jenkins.

@kedark3 kedark3 force-pushed the vm_name_enhancement_2 branch 2 times, most recently from 799a654 to 0d14653 Compare January 16, 2020 20:46
@dajoRH dajoRH added the lint-ok label Jan 16, 2020
@kedark3 kedark3 force-pushed the vm_name_enhancement_2 branch from 0d14653 to 8e55455 Compare January 16, 2020 20:51
@john-dupuy john-dupuy mentioned this pull request Jan 17, 2020
Merged
john-dupuy
john-dupuy approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, I do think we should have a Jenkins run without --composite-uncollect to run a few more tests.

cfme/test_requirements.py Show resolved Hide resolved
@john-dupuy john-dupuy changed the title [RFR][NOTEST]Vm name enhancement 2 [1LP][RFR][NOTEST]Vm name enhancement 2 Jan 17, 2020
@kedark3 kedark3 force-pushed the vm_name_enhancement_2 branch 2 times, most recently from 8e52a80 to 45d3ef1 Compare January 17, 2020 15:19
@kedark3 kedark3 force-pushed the vm_name_enhancement_2 branch from 45d3ef1 to 78e877f Compare January 17, 2020 15:21
@dajoRH
Copy link
Contributor

dajoRH commented Jan 17, 2020

I detected some fixture changes in commit 78e877f

The local fixture mark_vm_as_appliance is used in the following files:

  • cfme/tests/cloud/test_cloud_timelines.py
    • test_cloud_timeline_diagnostic

The local fixture control_policy is used in the following files:

  • cfme/tests/cloud/test_cloud_timelines.py
    • test_cloud_timeline_policy_event

The local fixture azone is used in the following files:

  • cfme/tests/cloud/test_cloud_timelines.py
    • test_cloud_timeline_create_event
    • test_cloud_timeline_stop_event
    • test_cloud_timeline_start_event
    • test_cloud_timeline_rename_event
    • test_cloud_timeline_delete_event

The local fixture vm_name is used in the following files:

  • cfme/tests/cloud_infra_common/test_power_control_rest.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@jawatts jawatts merged commit 950033f into ManageIQ:master Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@john-dupuy john-dupuy john-dupuy approved these changes

@jawatts jawatts jawatts approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees
No one assigned
Labels
enhancement lint-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kedark3 @dajoRH @jawatts @john-dupuy @mshriver