This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR][NOTEST] Added default template parameter in create_vm fixture. #9861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbulage
requested review from
kedark3,
john-dupuy and
digitronik
and removed request for
kedark3 and
john-dupuy
January 22, 2020 09:45
kedark3
reviewed
Jan 22, 2020
kedark3
approved these changes
Jan 22, 2020
john-dupuy
changed the title
[RFR][NOTEST] Added default template parameter in create_vm fixture.
[WIPTEST][NOTEST] Added default template parameter in create_vm fixture.
Jan 24, 2020
sbulage
changed the title
[WIPTEST][NOTEST] Added default template parameter in create_vm fixture.
[RFR][NOTEST] Added default template parameter in create_vm fixture.
Feb 4, 2020
john-dupuy
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small suggestion
john-dupuy
changed the title
[RFR][NOTEST] Added default template parameter in create_vm fixture.
[1LP][WIPTEST][NOTEST] Added default template parameter in create_vm fixture.
Feb 6, 2020
kedark3
approved these changes
Feb 6, 2020
sbulage
changed the title
[1LP][WIPTEST][NOTEST] Added default template parameter in create_vm fixture.
[1LP][RFR][NOTEST] Added default template parameter in create_vm fixture.
Feb 7, 2020
I detected some fixture changes in commit 0721d94 Show fixturesThe global fixture
The global fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
changed the title
[1LP][RFR][NOTEST] Added default template parameter in create_vm fixture.
[1LP][WIP][NOTEST] Added default template parameter in create_vm fixture.
Feb 7, 2020
sbulage
changed the title
[1LP][WIP][NOTEST] Added default template parameter in create_vm fixture.
[1LP][RFR][NOTEST] Added default template parameter in create_vm fixture.
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
If no template parameter provided then use DSL template.
A small enhancement in PR #9850
create_vm
fixture.