Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR][NOTEST] Added default template parameter in create_vm fixture. #9861

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Jan 22, 2020

Purpose or Intent

If no template parameter provided then use DSL template.
A small enhancement in PR #9850

  • Add default template parameter to create_vm fixture.

@sbulage sbulage requested review from kedark3, john-dupuy and digitronik and removed request for kedark3 and john-dupuy January 22, 2020 09:45
@dajoRH dajoRH added the lint-ok label Jan 22, 2020
@sbulage sbulage requested a review from valaparthvi January 22, 2020 09:50
cfme/fixtures/vm.py Outdated Show resolved Hide resolved
@john-dupuy john-dupuy changed the title [RFR][NOTEST] Added default template parameter in create_vm fixture. [WIPTEST][NOTEST] Added default template parameter in create_vm fixture. Jan 24, 2020
@sbulage sbulage changed the title [WIPTEST][NOTEST] Added default template parameter in create_vm fixture. [RFR][NOTEST] Added default template parameter in create_vm fixture. Feb 4, 2020
@dajoRH dajoRH removed the WIP-testing label Feb 4, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small suggestion

cfme/fixtures/vm.py Outdated Show resolved Hide resolved
@john-dupuy john-dupuy changed the title [RFR][NOTEST] Added default template parameter in create_vm fixture. [1LP][WIPTEST][NOTEST] Added default template parameter in create_vm fixture. Feb 6, 2020
@sbulage sbulage changed the title [1LP][WIPTEST][NOTEST] Added default template parameter in create_vm fixture. [1LP][RFR][NOTEST] Added default template parameter in create_vm fixture. Feb 7, 2020
@dajoRH dajoRH removed the WIP-testing label Feb 7, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Feb 7, 2020

I detected some fixture changes in commit 0721d94

Show fixtures

The global fixture create_vm_modscope is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_actions.py
    • policy_for_testing
  • cfme/tests/ansible/test_embedded_ansible_automate.py
    • alert_profile
    • test_embedded_ansible_custom_button_localhost
    • test_embedded_ansible_custom_button_target_machine
    • test_embedded_ansible_custom_button_specific_hosts
    • test_alert_run_ansible_playbook

The global fixture create_vm is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_services.py
    • ansible_linked_vm_action
    • ansible_policy_linked_vm
  • cfme/tests/automate/test_common_methods.py
    • test_vm_retire_extend
    • test_move_vm_into_folder
  • cfme/tests/automate/test_service_automate.py
    • test_retire_vm_now
  • cfme/tests/automate/test_vmware_methods.py
  • cfme/tests/cloud/test_cloud_events.py
    • test_vm_capture
  • cfme/tests/cloud/test_cloud_timelines.py
    • mark_vm_as_appliance
    • control_policy
    • azone
    • test_cloud_timeline_create_event
    • test_cloud_timeline_policy_event
    • test_cloud_timeline_stop_event
    • test_cloud_timeline_start_event
    • test_cloud_timeline_diagnostic
    • test_cloud_timeline_rename_event
    • test_cloud_timeline_delete_event
  • cfme/tests/cloud_infra_common/test_cockpit_server.py
    • test_cockpit_server_role
  • cfme/tests/cloud_infra_common/test_discovery_and_support.py
    • test_vm_discovery
  • cfme/tests/cloud_infra_common/test_genealogy.py
  • cfme/tests/cloud_infra_common/test_html5_vm_console.py
    • test_html5_vm_console
  • cfme/tests/cloud_infra_common/test_power_control_rest.py
    • vm_name
    • wait_for_vm_state_change
    • test_stop_vm_rest
    • test_start_vm_rest
    • test_suspend_vm_rest
    • test_reset_vm_rest
  • cfme/tests/control/test_alerts.py
    • wait_candu
    • ssh
    • test_alert_rtp
    • test_alert_timeline_cpu
    • test_alert_snmp
  • cfme/tests/infrastructure/test_tenant_quota.py
    • test_quota_not_fails_after_vm_reconfigure_disk_remove
  • cfme/tests/services/test_dialog_element_in_catalog.py
    • test_service_dialog_expression_method
  • cfme/tests/webui/test_general_ui.py
    • test_vm_right_size_recommendation_back_button

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@mshriver mshriver changed the title [1LP][RFR][NOTEST] Added default template parameter in create_vm fixture. [1LP][WIP][NOTEST] Added default template parameter in create_vm fixture. Feb 7, 2020
@dajoRH dajoRH added the WIP label Feb 7, 2020
@sbulage sbulage changed the title [1LP][WIP][NOTEST] Added default template parameter in create_vm fixture. [1LP][RFR][NOTEST] Added default template parameter in create_vm fixture. Feb 7, 2020
@dajoRH dajoRH removed the WIP label Feb 7, 2020
@mshriver mshriver merged commit d28db2d into ManageIQ:master Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants