For Choice validation, use instance variables and not payload #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All classes currently populate the instance variables and then validate the state
agrare
approved these changes
Sep 20, 2024
agrare
added a commit
that referenced
this pull request
Oct 28, 2024
Added - Add WorkflowBase base class for Workflow (#279) - Add tool for using the aws stepfunctions simulator (#244) - Implement Map state (#184) - Add Map State Tolerated Failure (#282) - Run Map iterations in parallel up to MaxConcurrency (#283) - Implement Parallel State (#291) Changed - More granular compare_key and determine path at initialization time (#274) - For Choice validation, use instance variables and not payload (#277) - Return ExceedToleratedFailureThreshold if ToleratedFailureCount/Percentage is present (#285) Fixed - Fix case on log messages (#280) - Handle either ToleratedFailureCount or ToleratedFailurePercentage (#284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial
All classes currently populate the instance variables and then validate the state
When I was working #275, this was the only real
initializethat changed.The changes seemed legit.